[BOLT] Fix setHasSymbolsWithFileName #92625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function is used to ignore the parameter and set `HasSymbolsWithFileName` unconditionally.
aaupov
requested review from
ayermolo,
dcci,
maksfb and
rafaelauler
as code owners
Member
|
@llvm/pr-subscribers-bolt Author: Amir Ayupov (aaupov) ChangesThe function is used to ignore the parameter and set Full diff: https://github.com/llvm/llvm-project/pull/92625.diff 1 Files Affected:
diff --git a/bolt/include/bolt/Core/BinaryContext.h b/bolt/include/bolt/Core/BinaryContext.h
index 75765819ac464..792c09dd7c467 100644
--- a/bolt/include/bolt/Core/BinaryContext.h
+++ b/bolt/include/bolt/Core/BinaryContext.h
@@ -359,7 +359,7 @@ class BinaryContext {
void setFileBuildID(StringRef ID) { FileBuildID = std::string(ID); }
bool hasSymbolsWithFileName() const { return HasSymbolsWithFileName; }
- void setHasSymbolsWithFileName(bool Value) { HasSymbolsWithFileName = true; }
+ void setHasSymbolsWithFileName(bool Value) { HasSymbolsWithFileName = Value; }
/// Return true if relocations against symbol with a given name
/// must be created.
|
dcci
requested changes
May 22, 2024
Member
dcci
left a comment
dcci
left a comment
There was a problem hiding this comment.
Do we need this function at all? Can something be ever set to false?
Contributor
Author
|
Yes, if the input file has file symbols stripped, we will incorrectly set it to true. |
aaupov
added a commit
to aaupov/llvm-project
that referenced
this pull request
May 23, 2024
This reverts commit ccabbff. Reintroduce allow-stripped as a fallback mechanism after enforcement of HasSymbolsWithFileName was fixed in llvm#92625.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is used to ignore the parameter and set
HasSymbolsWithFileNameunconditionally.