Skip to content

[lsan][test] Allow testcase to execute on remote targets without not utility #87350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

rjmansfield
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Apr 2, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: None (rjmansfield)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/87350.diff

1 Files Affected:

  • (modified) compiler-rt/test/lsan/TestCases/create_thread_leak.cpp (+3-3)
diff --git a/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp b/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp
index 564d4b66384e8a..994b0e644632eb 100644
--- a/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp
+++ b/compiler-rt/test/lsan/TestCases/create_thread_leak.cpp
@@ -1,9 +1,9 @@
 // Test handling of arg and retval of child thread.
 
 // RUN: %clangxx_lsan -pthread %s -o %t
-// RUN: %run not %t 10 1 0 0 2>&1 | FileCheck %s --check-prefixes=LEAK,LEAK123
-// RUN: %run not %t 10 0 1 0 2>&1 | FileCheck %s --check-prefixes=LEAK,LEAK234
-// RUN: %run not %t 10 0 0 1 2>&1 | FileCheck %s --check-prefixes=LEAK,LEAK234
+// RUN: not %run %t 10 1 0 0 2>&1 | FileCheck %s --check-prefixes=LEAK,LEAK123
+// RUN: not %run %t 10 0 1 0 2>&1 | FileCheck %s --check-prefixes=LEAK,LEAK234
+// RUN: not %run %t 10 0 0 1 2>&1 | FileCheck %s --check-prefixes=LEAK,LEAK234
 // RUN: %run %t 10 0 0 0
 
 // This test appears to be flaky on x86_64-darwin buildbots.

@rjmansfield
Copy link
Contributor Author

Ping? This test runs 'not' on the target and not the host, so remote execution of this test will fail otherwise.

Copy link
Contributor

@fmayer fmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rjmansfield
Copy link
Contributor Author

Thanks, could someone with commit access merge on my behalf?

@fmayer fmayer merged commit e51fc36 into llvm:main Aug 29, 2024
1 check passed
@rjmansfield rjmansfield deleted the no_not_remote branch August 30, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants