Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang] Fix Clang language extension documentation markup for __builtin_arm_trap. #85310

Merged

Conversation

tahonermann
Copy link
Contributor

No description provided.

@tahonermann tahonermann self-assigned this Mar 14, 2024
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Mar 14, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 14, 2024

@llvm/pr-subscribers-clang

Author: Tom Honermann (tahonermann)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/85310.diff

1 Files Affected:

  • (modified) clang/docs/LanguageExtensions.rst (+1-1)
diff --git a/clang/docs/LanguageExtensions.rst b/clang/docs/LanguageExtensions.rst
index 9347703e96e21a..225736009d4869 100644
--- a/clang/docs/LanguageExtensions.rst
+++ b/clang/docs/LanguageExtensions.rst
@@ -3444,7 +3444,7 @@ Query for this feature with ``__has_builtin(__builtin_debugtrap)``.
 Query for this feature with ``__has_builtin(__builtin_trap)``.
 
 ``__builtin_arm_trap``
-------------------
+----------------------
 
 ``__builtin_arm_trap`` is an AArch64 extension to ``__builtin_trap`` which also accepts a compile-time constant value, encoded directly into the trap instruction for later inspection.
 

@tahonermann tahonermann requested a review from TNorthover March 14, 2024 21:00
@tahonermann
Copy link
Contributor Author

@TNorthover, doc builds are failing because of this.

Warning, treated as error:
/home/runner/work/llvm-project/llvm-project/clang-build/tools/clang/docs/LanguageExtensions.rst:3447:Title underline too short.

``__builtin_arm_trap``
------------------

@tahonermann tahonermann force-pushed the thonerma-__builtin_arm_trap-doc-fix branch from f1fe6f6 to e88e3fe Compare March 14, 2024 21:34
@tahonermann tahonermann requested a review from sam-mccall March 14, 2024 21:44
Copy link
Collaborator

@sam-mccall sam-mccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and sorry for piling on extra errors...

@tahonermann tahonermann merged commit 92b5601 into llvm:main Mar 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants