[InstCombine] Simplify with.overflow intrinsics with assumption information #84016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtcxzyw
added a commit
to dtcxzyw/llvm-opt-benchmark
that referenced
this pull request
Mar 5, 2024
|
Closed in favor of rust-lang/rust#122282. |
|
Hmm, this is the first step, and we still need subsequent PRs to complete this simplification. |
|
@DianQK Should I close this PR since rust-lang/rust#122975 landed? |
I believe it will take at least two more PRs to resolve this issue. The first one is rust-lang/rust#123256 (comment). Given the differences in inlining rules between Rust and LLVM, there are likely some edge cases that still cannot be resolved. |
|
This looks ready and rust-lang/rust#122975 looks orthogonal to me, should we undraft it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: rust-lang/hashbrown#509 #80637