[builtins][arm64] Implement __init_cpu_features_resolver on Apple platforms #75636
Conversation
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
| static struct { | ||
| const char *sysctl_name; | ||
| enum CPUFeatures feature; | ||
| } features[] = { |
There was a problem hiding this comment.
Do you need support for AdvSIMD_HPFPCvt, FEAT_LSE2, FEAT_SHA512 or for other feature in Function Multi Versioning? Specification is not final yet and open to proposals.
There was a problem hiding this comment.
Sure, I can add entries for those. Looks like I missed them in my manual intersection of the sysctl docs with the FEAT_* table.
edit: I see you're asking a different question than I thought. Yeah, those three would probably be useful.
Specification is not final yet and open to proposals.
Any word on when FMV might come out of beta?
There was a problem hiding this comment.
Looks like we're just about out of bits in __aarch64_cpu_features.features.
There was a problem hiding this comment.
Another thing that came up when discussing the frontend attributes for these: we may want to have user-selectable overrides for the priorities for (hypothetical) cases where the prescribed numbers in the table don't match the selection behavior we need at runtime. I don't have a concrete example in mind yet.
There was a problem hiding this comment.
Looks like we're just about out of bits in
__aarch64_cpu_features.features.
Next field features2 can be added to __aarch64_cpu_features with setting FEAT_EXT bit to 1 and changing initialization condition to if (__aarch64_cpu_features.features & (1ULL << FEAT_INIT) )
There was a problem hiding this comment.
Any word on when FMV might come out of beta?
There's no specific deadline right now, possibly within a year or half - we want to collect and address all feedback on FMV from partners and compilers communities.
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4 [skip ci]
jroelofs
changed the base branch from
users/jroelofs/spr/main.builtinsarm64-implement-__init_cpu_features_resolver-on-apple-platforms
to
main
jroelofs
deleted the
users/jroelofs/spr/builtinsarm64-implement-__init_cpu_features_resolver-on-apple-platforms
branch
This is a re-land of llvm#73685
This is a re-land of llvm#73685
This is a re-land of #73685