Skip to content

[AArch64] Split Ampere1Write_Arith into rr/ri and rs/rx InstRWs.#66384

Merged
davemgreen merged 1 commit intollvm:mainfrom
davemgreen:gh-ampere1schedfix
Sep 14, 2023
Merged

[AArch64] Split Ampere1Write_Arith into rr/ri and rs/rx InstRWs.#66384
davemgreen merged 1 commit intollvm:mainfrom
davemgreen:gh-ampere1schedfix

Conversation

@davemgreen
Copy link
Collaborator

The ampere1 scheduling model uses IsCheapLSL predicates for ADDXri and ADDWrr instructions, which only have 3 operands. In attempting to check that the third is a shift, the predicate can attempt to access an out of bounds operand, hitting an assert. This splits the rr/ri instructions (which can never have shifts) from the rs/rx instructions to ensure they both work correctly. Ampere1Write_1cyc_1AB was chosen for the rr/ir instructions to match the cheap case.

This also sets CompleteModel = 0 for the ampere1 scheduling model, as at runtime under debug it will attempt to check that as well as all instructions having scheduling info, there is information for each output operand.

DefIdx 1 exceeds machine model writes for
renamable $w9, renamable $w8 = LDPWi renamable $x8, 0
(Try with MCSchedModel.CompleteModel set to false)incomplete machine model

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants