Fix test added in #155148 work with Windows style path separators. #155354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281.
|
@llvm/pr-subscribers-testing-tools Author: None (dyung) ChangesShould fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281. The test (and the followup fix in #155303) did not properly account for Windows style path separators. Full diff: https://github.com/llvm/llvm-project/pull/155354.diff 1 Files Affected:
diff --git a/llvm/utils/lit/tests/pass-test-update.py b/llvm/utils/lit/tests/pass-test-update.py
index f23bce9838f35..00a4025be660e 100644
--- a/llvm/utils/lit/tests/pass-test-update.py
+++ b/llvm/utils/lit/tests/pass-test-update.py
@@ -13,7 +13,7 @@
# CHECK: Traceback (most recent call last):
# CHECK: File {{.*}}, line {{.*}}, in {{.*}}
# CHECK: update_output = test_updater(result, test)
-# CHECK: File "{{.*}}/should_not_run.py", line {{.*}}, in should_not_run
+# CHECK: File "{{.*}}{{/|\\}}should_not_run.py", line {{.*}}, in should_not_run
# CHECK: raise Exception("this test updater should only run on failure")
# CHECK: Exception: this test updater should only run on failure
# CHECK: ********************
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/21765 Here is the relevant piece of the build log for the reference |
|
Thanks! |
hnrklssn
pushed a commit
to hnrklssn/llvm-project
that referenced
this pull request
Sep 11, 2025
llvm#155354) Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281. The test (and the followup fix in llvm#155303) did not properly account for Windows style path separators. (cherry picked from commit 7d35e29)
hnrklssn
pushed a commit
to hnrklssn/llvm-project
that referenced
this pull request
Sep 12, 2025
llvm#155354) Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281. The test (and the followup fix in llvm#155303) did not properly account for Windows style path separators. (cherry picked from commit 7d35e29)
kateinoigakukun
pushed a commit
to kateinoigakukun/llvm-project
that referenced
this pull request
Sep 17, 2025
llvm#155354) Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281. The test (and the followup fix in llvm#155303) did not properly account for Windows style path separators. (cherry picked from commit 7d35e29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281.
The test (and the followup fix in #155303) did not properly account for Windows style path separators.