-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Fix test added in #155148 work with Windows style path separators. #155354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281.
@llvm/pr-subscribers-testing-tools Author: None (dyung) ChangesShould fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281. The test (and the followup fix in #155303) did not properly account for Windows style path separators. Full diff: https://github.com/llvm/llvm-project/pull/155354.diff 1 Files Affected:
diff --git a/llvm/utils/lit/tests/pass-test-update.py b/llvm/utils/lit/tests/pass-test-update.py
index f23bce9838f35..00a4025be660e 100644
--- a/llvm/utils/lit/tests/pass-test-update.py
+++ b/llvm/utils/lit/tests/pass-test-update.py
@@ -13,7 +13,7 @@
# CHECK: Traceback (most recent call last):
# CHECK: File {{.*}}, line {{.*}}, in {{.*}}
# CHECK: update_output = test_updater(result, test)
-# CHECK: File "{{.*}}/should_not_run.py", line {{.*}}, in should_not_run
+# CHECK: File "{{.*}}{{/|\\}}should_not_run.py", line {{.*}}, in should_not_run
# CHECK: raise Exception("this test updater should only run on failure")
# CHECK: Exception: this test updater should only run on failure
# CHECK: ********************
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/21765 Here is the relevant piece of the build log for the reference
|
Thanks! |
llvm#155354) Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281. The test (and the followup fix in llvm#155303) did not properly account for Windows style path separators. (cherry picked from commit 7d35e29)
llvm#155354) Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281. The test (and the followup fix in llvm#155303) did not properly account for Windows style path separators. (cherry picked from commit 7d35e29)
llvm#155354) Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281. The test (and the followup fix in llvm#155303) did not properly account for Windows style path separators. (cherry picked from commit 7d35e29)
Should fix Windows build bot failures such as https://lab.llvm.org/buildbot/#/builders/46/builds/22281.
The test (and the followup fix in #155303) did not properly account for Windows style path separators.