[mlir][linalg][nfc] Move vectorization tests #141656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves: * mlir/test/Dialect/Linalg/vectorization-with-patterns.mlir * mlir/test/Dialect/Linalg/vectorization.mlir * mlir/test/Dialect/Linalg/vectorization-unsupported.mlir to: * mlir/test/Dialect/Linalg/vectorization/ This patch implements part of llvm#141025 - please see the ticket for full context.
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-linalg Author: Andrzej Warzyński (banach-space) ChangesMoves:
to:
This patch implements part of #141025 - please see the ticket for full Full diff: https://github.com/llvm/llvm-project/pull/141656.diff 3 Files Affected:
diff --git a/mlir/test/Dialect/Linalg/vectorization-with-patterns.mlir b/mlir/test/Dialect/Linalg/vectorization/linalg-ops-with-patterns.mlir
similarity index 100%
rename from mlir/test/Dialect/Linalg/vectorization-with-patterns.mlir
rename to mlir/test/Dialect/Linalg/vectorization/linalg-ops-with-patterns.mlir
diff --git a/mlir/test/Dialect/Linalg/vectorization.mlir b/mlir/test/Dialect/Linalg/vectorization/linalg-ops.mlir
similarity index 100%
rename from mlir/test/Dialect/Linalg/vectorization.mlir
rename to mlir/test/Dialect/Linalg/vectorization/linalg-ops.mlir
diff --git a/mlir/test/Dialect/Linalg/vectorization-unsupported.mlir b/mlir/test/Dialect/Linalg/vectorization/unsupported.mlir
similarity index 100%
rename from mlir/test/Dialect/Linalg/vectorization-unsupported.mlir
rename to mlir/test/Dialect/Linalg/vectorization/unsupported.mlir
|
hanhanW
reviewed
May 28, 2025
Sure, let me extend this PR. TBH, I kept it small to make sure some progress is made - I am trying to squeeze this in between other things 😅 |
* In vectorize-convolution.mlir, switch from `-test-linalg-transform-patterns=test-linalg-to-vector-patterns` to `transform.structured.vectorize_children_and_apply_patterns` (for consistency with other tests for vectorization). * Move + rename the remaining vectorization tests. * Add comments.
hanhanW
approved these changes
May 30, 2025
|
You may want to add |
sivan-shani
pushed a commit
to sivan-shani/llvm-project
that referenced
this pull request
Jun 3, 2025
Moves all the remaining Linalg vectorization tests from: * `mlir/tests/Dialect/Linalg/*` to: * `mlir/tests/Dialect/Linalg/vectorization/*` To maintain consistency within tests, `vectorize-convolution.mlir` was updated to use: * `transform.structured.vectorize_children_and_apply_patterns` instead of: * `-test-linalg-transform-patterns=test-linalg-to-vector-patterns` This change required minor updates to some `CHECK` lines, reflecting only reordering of ops due to an additional pattern being applied. Closes llvm#141025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the remaining Linalg vectorization tests from:
mlir/tests/Dialect/Linalg/*to:
mlir/tests/Dialect/Linalg/vectorization/*To maintain consistency within tests,
vectorize-convolution.mlirwas updated to use:
transform.structured.vectorize_children_and_apply_patternsinstead of:
-test-linalg-transform-patterns=test-linalg-to-vector-patternsThis change required minor updates to some
CHECKlines, reflectingonly reordering of ops due to an additional pattern being applied.
Closes #141025