[libc++] Add _LIBCPP_NO_UNIQUE_ADDRESS to flat_{,multi}map::value_compare#137594
Merged
[libc++] Add _LIBCPP_NO_UNIQUE_ADDRESS to flat_{,multi}map::value_compare#137594
Conversation
llvmbot
added
the
libc++
philnik777
changed the title
Member
|
@llvm/pr-subscribers-libcxx Author: Nikolas Klauser (philnik777) ChangesThis breaks the ABI of Full diff: https://github.com/llvm/llvm-project/pull/137594.diff 2 Files Affected:
diff --git a/libcxx/include/__flat_map/flat_map.h b/libcxx/include/__flat_map/flat_map.h
index f5abfd0985280..f5e9756ff6a60 100644
--- a/libcxx/include/__flat_map/flat_map.h
+++ b/libcxx/include/__flat_map/flat_map.h
@@ -114,7 +114,7 @@ class flat_map {
class value_compare {
private:
- key_compare __comp_;
+ _LIBCPP_NO_UNIQUE_ADDRESS key_compare __comp_;
_LIBCPP_HIDE_FROM_ABI value_compare(key_compare __c) : __comp_(__c) {}
friend flat_map;
diff --git a/libcxx/include/__flat_map/flat_multimap.h b/libcxx/include/__flat_map/flat_multimap.h
index ea77fb5d79bd2..15fcd7995ad0a 100644
--- a/libcxx/include/__flat_map/flat_multimap.h
+++ b/libcxx/include/__flat_map/flat_multimap.h
@@ -115,7 +115,7 @@ class flat_multimap {
class value_compare {
private:
- key_compare __comp_;
+ _LIBCPP_NO_UNIQUE_ADDRESS key_compare __comp_;
_LIBCPP_HIDE_FROM_ABI value_compare(key_compare __c) : __comp_(__c) {}
friend flat_multimap;
|
frederick-vs-ja
approved these changes
Apr 29, 2025
huixie90
approved these changes
May 3, 2025
Member
huixie90
left a comment
huixie90
left a comment
There was a problem hiding this comment.
I agree this is very unlikely to break anything, because value_compare is not stored in flat_map. The only situation this can break anything is when user do m.value_compare() and then store the results in a struct.
Could we add a unittest in libcxx folder?
Otherwise LGTM
ldionne
approved these changes
May 7, 2025
Member
ldionne
left a comment
ldionne
left a comment
There was a problem hiding this comment.
I think this is very low risk if we do it right now and backport it. I also don't see what test we'd add for this in order to really add value. LGTM as is.
github-project-automation
bot
moved this from Needs Triage
to Needs Merge
in LLVM Release Status
github-project-automation
bot
moved this from Needs Merge
to Done
in LLVM Release Status
Member
|
/cherry-pick ed0aa99 |
Member
|
/pull-request #138880 |
alexrp
added a commit
to ziglang/zig
that referenced
this pull request
May 10, 2025
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Jun 12, 2025
…pare (llvm#137594) This breaks the ABI of `flat_{,multi}map::value_compare`, but this type has only been introduced in LLVM 20, so it should be very unlikely that we break anybody if we back-port this now. (cherry picked from commit ed0aa99)
dasimmet
pushed a commit
to dasimmet/zig
that referenced
this pull request
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks the ABI of
flat_{,multi}map::value_compare, but this type has only been introduced in LLVM 20, so it should be very unlikely that we break anybody if we back-port this now.