-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[libc++] constexpr flat_map #137453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc++] constexpr flat_map #137453
Changes from all commits
22b63c9
77d60c2
ca08a9b
de6797e
dcdaf4e
c511993
68c2ff2
e35b591
b675599
4288367
f1418c9
9d4b6f2
7bc0fa3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1298,6 +1298,9 @@ module std [system] { | |
|
||
header "flat_map" | ||
export * | ||
export std.algorithm.ranges_sort | ||
export std.ranges.zip_view | ||
export std.tuple | ||
Comment on lines
+1301
to
+1303
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No change requested. Do you have any idea why these missing exports were not caught before? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The short answer: I don't think I have any clue on how clang modules work exactly. I don't even know why exporting these are required at all. These things are all internal details of the implementation of However, as soon as I added There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is quite weird. Not sure whether this is related to that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
But how does this explain a linker error... |
||
} | ||
|
||
module flat_set { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "only
flat_map
" part looks incorrect; #127876 shows thatlist
,forward_list
andpriority_queue
have already been implemented as well.