[KeyInstr][Clang] For range stmt atoms #134647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2025
OCHyams
force-pushed
the
users/OCHyams/ki-clang-for
branch
from
375ca9f to
c4b2db1
Compare
OCHyams
force-pushed
the
users/OCHyams/ki-clang-for-range
branch
from
2484a49 to
bd77fcb
Compare
OCHyams
force-pushed
the
users/OCHyams/ki-clang-for
branch
from
2317236 to
74a6ebd
Compare
OCHyams
force-pushed
the
users/OCHyams/ki-clang-for-range
branch
from
bd77fcb to
9e7139b
Compare
SLTozer
reviewed
May 27, 2025
| // RUN: %clang_cc1 -gkey-instructions %s -debug-info-kind=line-tables-only -emit-llvm -o - \ | ||
| // RUN: | FileCheck %s --implicit-check-not atomGroup --implicit-check-not atomRank | ||
|
|
||
| // Perennial quesiton: should the inc be its own source atom or not |
There was a problem hiding this comment.
Suggested change
| // Perennial quesiton: should the inc be its own source atom or not | |
| // Perennial question: should the inc be its own source atom or not |
|
|
||
| // The stores in the setup (stores to __RANGE1, __BEGIN1, __END1) are all | ||
| // marked as Key. Unclear whether that's desirable. Keep for now as that's | ||
| // least risky. |
There was a problem hiding this comment.
For posterity, maybe explain what "risky" means in this context?
clang/lib/CodeGen/CGStmt.cpp
Outdated
Comment on lines
1456
to
1457
| if (auto *I = dyn_cast<llvm::Instruction>(BoolCondVal)) | ||
| addInstToNewSourceAtom(I, nullptr); |
There was a problem hiding this comment.
Not a big fan of the shadowing here, it seems like it'd make things harder to parse at a glance?
This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. The Key Instructions project is introduced, including a "quick summary" section at the top which adds context for this PR, here: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668 The feature is only functional in LLVM if LLVM is built with CMake flag LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed. The Clang-side work is demoed here: #130943
OCHyams
force-pushed
the
users/OCHyams/ki-clang-for-range
branch
from
9e7139b to
f01b5ff
Compare
Co-authored-by: Stephen Tozer <stephen.tozer@sony.com>
Co-authored-by: Stephen Tozer <stephen.tozer@sony.com>
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/159/builds/23586 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/26730 Here is the relevant piece of the build log for the reference |
OCHyams
added a commit
that referenced
this pull request
Jun 3, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/33693 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/27497 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/29238 Here is the relevant piece of the build log for the reference |
OCHyams
added a commit
that referenced
this pull request
Jun 4, 2025
This reverts commit e6529dc with crash fixed. Original PR #134647 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. RFC: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668 The feature is only functional in LLVM if LLVM is built with CMake flag LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jun 4, 2025
This reverts commit e6529dc with crash fixed. Original PR llvm/llvm-project#134647 This patch is part of a stack that teaches Clang to generate Key Instructions metadata for C and C++. RFC: https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668 The feature is only functional in LLVM if LLVM is built with CMake flag LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.
The Key Instructions project is introduced, including a "quick summary" section
at the top which adds context for this PR, here:
https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668
The feature is only functional in LLVM if LLVM is built with CMake flag
LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed.
The Clang-side work is demoed here:
#130943