Fix to the libc BUILD.bazel file after changing atan_utils.h deps. #134128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-libc Author: Amy Huang (amykhuang) ChangesAdditional fix for libc BUILD.bazel after commit 8741412 (#133980) This seems to match libc/src/math/generic/CMakeLists.txt. Full diff: https://github.com/llvm/llvm-project/pull/134128.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 1cb48974f4905..a9357485d3a10 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -1881,7 +1881,6 @@ libc_support_library(
name = "inv_trigf_utils",
srcs = ["src/math/generic/inv_trigf_utils.cpp"],
hdrs = [
- "src/math/generic/atan_utils.h",
"src/math/generic/inv_trigf_utils.h",
],
deps = [
|
lntue
approved these changes
Apr 2, 2025
Contributor
|
Shouldn't this be already fixed by 07504af? |
Contributor
|
nevermind, I can see that atan_utils.h has its own Bazel library, and indeed shouldn't be in the hdrs of inv_trigf_utils |
vonosmas
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fix for libc BUILD.bazel after commit 8741412 (#133980)
This seems to match libc/src/math/generic/CMakeLists.txt.