[NFC][analyzer] Fix header comment in CreateCheckerManager.cpp

[NagyDonat]

Apparently it was copied from CheckerManager.h without changes.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Donát Nagy (NagyDonat)

Changes

Apparently it was copied from CheckerManager.h without changes.

---

Full diff: https://github.com/llvm/llvm-project/pull/129055.diff

1 Files Affected:

• (modified) clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp (+4-2)

diff --git a/clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp b/clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp
index f60221ad7587e..7ca7f09b6eb23 100644
--- a/clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp
+++ b/clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp
@@ -1,4 +1,4 @@
-//===- CheckerManager.h - Static Analyzer Checker Manager -------*- C++ -*-===//
+//===- CreateCheckerManager.cpp - Checker Manager constructor ---*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,7 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// Defines the Static Analyzer Checker Manager.
+// Defines the constructors and the destructor of the Static Analyzer Checker
+// Manager which cannot be placed under 'Core' because they depend on the
+// CheckerRegistry.
 //
 //===----------------------------------------------------------------------===//
 

[llvmbot]

@llvm/pr-subscribers-clang-static-analyzer-1

Author: Donát Nagy (NagyDonat)

Changes

Apparently it was copied from CheckerManager.h without changes.

---

Full diff: https://github.com/llvm/llvm-project/pull/129055.diff

1 Files Affected:

• (modified) clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp (+4-2)

diff --git a/clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp b/clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp
index f60221ad7587e..7ca7f09b6eb23 100644
--- a/clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp
+++ b/clang/lib/StaticAnalyzer/Frontend/CreateCheckerManager.cpp
@@ -1,4 +1,4 @@
-//===- CheckerManager.h - Static Analyzer Checker Manager -------*- C++ -*-===//
+//===- CreateCheckerManager.cpp - Checker Manager constructor ---*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -6,7 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// Defines the Static Analyzer Checker Manager.
+// Defines the constructors and the destructor of the Static Analyzer Checker
+// Manager which cannot be placed under 'Core' because they depend on the
+// CheckerRegistry.
 //
 //===----------------------------------------------------------------------===//
 

[llvm-ci]

LLVM Buildbot has detected a new failure on builder lldb-arm-ubuntu running on linaro-lldb-arm-ubuntu while building clang at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/12094

Here is the relevant piece of the build log for the reference

Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: tools/lldb-dap/memory/TestDAP_memory.py (1159 of 2915)
PASS: lldb-api :: tools/lldb-dap/optimized/TestDAP_optimized.py (1160 of 2915)
PASS: lldb-api :: tools/lldb-dap/output/TestDAP_output.py (1161 of 2915)
PASS: lldb-api :: tools/lldb-dap/launch/TestDAP_launch.py (1162 of 2915)
PASS: lldb-api :: tools/lldb-dap/repl-mode/TestDAP_repl_mode_detection.py (1163 of 2915)
PASS: lldb-api :: tools/lldb-dap/evaluate/TestDAP_evaluate.py (1164 of 2915)
UNSUPPORTED: lldb-api :: tools/lldb-dap/restart/TestDAP_restart_runInTerminal.py (1165 of 2915)
UNSUPPORTED: lldb-api :: tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py (1166 of 2915)
UNSUPPORTED: lldb-api :: tools/lldb-dap/save-core/TestDAP_save_core.py (1167 of 2915)
PASS: lldb-api :: tools/lldb-dap/module/TestDAP_module.py (1168 of 2915)
FAIL: lldb-api :: tools/lldb-dap/restart/TestDAP_restart.py (1169 of 2915)
******************** TEST 'lldb-api :: tools/lldb-dap/restart/TestDAP_restart.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin --arch armv8l --build-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-arm-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-arm-ubuntu/llvm-project/lldb/test/API/tools/lldb-dap/restart -p TestDAP_restart.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 21.0.0git (https://github.com/llvm/llvm-project.git revision cad1de50ba06db8288da0e20c9aeffed328b8fce)
  clang revision cad1de50ba06db8288da0e20c9aeffed328b8fce
  llvm revision cad1de50ba06db8288da0e20c9aeffed328b8fce
Skipping the following test categories: ['libc++', 'dsym', 'gmodules', 'debugserver', 'objc']
========= DEBUG ADAPTER PROTOCOL LOGS =========
1740666527.789947987 stdin/stdout --> 
Content-Length: 344

{
  "arguments": {
    "adapterID": "lldb-native",
    "clientID": "vscode",
    "columnsStartAt1": true,
    "linesStartAt1": true,
    "locale": "en-us",
    "pathFormat": "path",
    "sourceInitFile": false,
    "supportsRunInTerminalRequest": true,
    "supportsStartDebuggingRequest": true,
    "supportsVariablePaging": true,
    "supportsVariableType": true
  },
  "command": "initialize",
  "seq": 1,
  "type": "request"
}
1740666527.792384863 stdin/stdout <-- 
Content-Length: 1631

[NagyDonat]

The failure is caused by tools/lldb-dap/restart/TestDAP_restart.py which is completely unrelated to my commit.