Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeepholeOpt: Remove null TargetRegisterInfo check #123933

Merged
merged 1 commit into from
Jan 23, 2025
Merged

PeepholeOpt: Remove null TargetRegisterInfo check #123933

merged 1 commit into from
Jan 23, 2025

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Jan 22, 2025

This cannot happen. Also simplify the LaneBitmask check from !none
to any.

@arsenm arsenm marked this pull request as ready for review January 22, 2025 11:57
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Jan 22, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 22, 2025
Merged
Merged
Merged
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Jan 23, 2025 •
edited
Loading

Merge activity

  • Jan 22, 8:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 22, 8:47 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 8:51 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 8:54 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 8:57 PM EST: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/peephole-opt-do-not-check-null-tii branch 3 times, most recently from b8c1f4c to c1b2b7e Compare January 23, 2025 01:45
Base automatically changed from users/arsenm/peephole-opt-do-not-check-null-tii to main January 23, 2025 01:47
@arsenm arsenm force-pushed the users/arsenm/peephole-opt-remove-null-tri-check branch 2 times, most recently from cd34163 to 32796a9 Compare January 23, 2025 01:50
@arsenm
PeepholeOpt: Remove null TargetRegisterInfo check
b761471 
This cannot happen. Also simplify the LaneBitmask check from !none
to any.
@arsenm arsenm force-pushed the users/arsenm/peephole-opt-remove-null-tri-check branch from 32796a9 to b761471 Compare January 23, 2025 01:54
@arsenm arsenm merged commit 6f69ade into main Jan 23, 2025
5 of 7 checks passed
@arsenm arsenm deleted the users/arsenm/peephole-opt-remove-null-tri-check branch January 23, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
llvm:codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arsenm