Skip to content

[Flang] [Semantics] [OpenMP] Add semantic checks for ALLOCATE directive #123421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025
Merged

[Flang] [Semantics] [OpenMP] Add semantic checks for ALLOCATE directive #123421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7844f5e
[Flang] [Semantics] [OpenMP] Add semantic checks for ALLOCATE
raghavendhra Jan 17, 2025
7a864d4
Remove unused variable and rebase with main branch.
raghavendhra Jan 17, 2025
d7922de
Rebase and addressed review comment by using Ultimate symbol.
raghavendhra Apr 24, 2025
3cf1119
Merge branch 'main' into allocate_directive_semantic_checks
raghavendhra Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions flang/lib/Semantics/check-omp-structure.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1712,6 +1712,28 @@ void OmpStructureChecker::Enter(const parser::OpenMPDeclarativeAllocate &x) {
const auto &objectList{std::get<parser::OmpObjectList>(x.t)};
PushContextAndClauseSets(dir.source, llvm::omp::Directive::OMPD_allocate);
const auto &clauseList{std::get<parser::OmpClauseList>(x.t)};
SymbolSourceMap currSymbols;
GetSymbolsInObjectList(objectList, currSymbols);
for (auto &[symbol, source] : currSymbols) {
if (IsPointer(*symbol)) {
context_.Say(source,
"List item '%s' in ALLOCATE directive must not have POINTER "
"attribute"_err_en_US,
source.ToString());
}
if (IsDummy(*symbol)) {
context_.Say(source,
"List item '%s' in ALLOCATE directive must not be a dummy "
"argument"_err_en_US,
source.ToString());
}
if (symbol->GetUltimate().has<AssocEntityDetails>()) {
context_.Say(source,
"List item '%s' in ALLOCATE directive must not be an associate "
"name"_err_en_US,
source.ToString());
}
}
for (const auto &clause : clauseList.v) {
CheckAlignValue(clause);
}
Expand Down
17 changes: 15 additions & 2 deletions flang/test/Semantics/OpenMP/allocate04.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,26 @@
! OpenMP Version 5.0
! 2.11.3 allocate Directive
! Only the allocator clause is allowed on the allocate directive
subroutine allocate()
! List item in ALLOCATE directive must not be a dummy argument
! List item in ALLOCATE directive must not have POINTER attribute
! List item in ALLOCATE directive must not be a associate name
subroutine allocate(z)
use omp_lib
use iso_c_binding

integer :: x, y
type(c_ptr), pointer :: p
integer :: x, y, z

associate (a => x)
!$omp allocate(x) allocator(omp_default_mem_alloc)

!ERROR: PRIVATE clause is not allowed on the ALLOCATE directive
!$omp allocate(y) private(y)
!ERROR: List item 'z' in ALLOCATE directive must not be a dummy argument
!$omp allocate(z)
!ERROR: List item 'p' in ALLOCATE directive must not have POINTER attribute
!$omp allocate(p)
!ERROR: List item 'a' in ALLOCATE directive must not be an associate name
!$omp allocate(a)
end associate
end subroutine allocate
Loading