Fix extra parenthesis in diagnostic #122055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following #120380, `err_pack_expansion_length_conflict` has one close paren too many. Remove the extra parenthesis.
hubert-reinterpretcast
added
the
clang:diagnostics
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Hubert Tong (hubert-reinterpretcast) ChangesFollowing #120380, Remove the extra parenthesis. Full diff: https://github.com/llvm/llvm-project/pull/122055.diff 1 Files Affected:
diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td
index 1a5541591a1608..2755d7bf579b7f 100644
--- a/clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -5878,7 +5878,7 @@ def err_pack_expansion_without_parameter_packs : Error<
"pack expansion does not contain any unexpanded parameter packs">;
def err_pack_expansion_length_conflict : Error<
"pack expansion contains parameter packs %0 and %1 that have different "
- "lengths (%2 vs. %select{|at least }3%4))">;
+ "lengths (%2 vs. %select{|at least }3%4)">;
def err_pack_expansion_length_conflict_multilevel : Error<
"pack expansion contains parameter pack %0 that has a different "
"length (%1 vs. %select{|at least }2%3) from outer parameter packs">;
|
hstk30-hw
approved these changes
Jan 8, 2025
hstk30-hw
deleted the
users/hubert-reinterpretcast/ClangDiag-fixExtraCloseParen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #120380,
err_pack_expansion_length_conflicthas one close paren too many.Remove the extra parenthesis.