Skip to content

[VPlan] Suppress leak in test #114624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

vitalybuka
Copy link
Collaborator

Probably needs a better fix. #114623

Created using spr 1.3.4
@llvmbot
Copy link
Member

llvmbot commented Nov 1, 2024

@llvm/pr-subscribers-llvm-transforms

Author: Vitaly Buka (vitalybuka)

Changes

Probably needs a better fix. #114623


Full diff: https://github.com/llvm/llvm-project/pull/114624.diff

1 Files Affected:

  • (modified) llvm/unittests/Transforms/Vectorize/VPlanTest.cpp (+3-2)
diff --git a/llvm/unittests/Transforms/Vectorize/VPlanTest.cpp b/llvm/unittests/Transforms/Vectorize/VPlanTest.cpp
index 0f1b52bd453e0f..4a8615cc086b08 100644
--- a/llvm/unittests/Transforms/Vectorize/VPlanTest.cpp
+++ b/llvm/unittests/Transforms/Vectorize/VPlanTest.cpp
@@ -732,8 +732,9 @@ TEST(VPBasicBlockTest, print) {
 
   LLVMContext C;
   auto *ScalarHeader = BasicBlock::Create(C, "");
-  VPIRBasicBlock *ScalarHeaderVPBB = new VPIRBasicBlock(ScalarHeader);
-  VPlan Plan(VPBB0, TC, VPBB1, ScalarHeaderVPBB);
+  // FIXME: This looks wrong.
+  auto ScalarHeaderVPBB = std::make_unique<VPIRBasicBlock>(ScalarHeader);
+  VPlan Plan(VPBB0, TC, VPBB1, ScalarHeaderVPBB.get());
   std::string FullDump;
   raw_string_ostream OS(FullDump);
   Plan.printDOT(OS);

@vitalybuka
Copy link
Collaborator Author

@fhahn Merging to fix bots, please check if it needs a better fix, or remove FIXME.

@vitalybuka vitalybuka merged commit 80b9f07 into main Nov 1, 2024
7 of 9 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/vplan-suppress-leak-in-test branch November 1, 2024 23:27
smallp-o-p pushed a commit to smallp-o-p/llvm-project that referenced this pull request Nov 3, 2024
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
@fhahn
Copy link
Contributor

fhahn commented Nov 4, 2024

Thanks for fixing this! Was reminded the hard way that LeakSan isn't part of ASan on macOS :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants