Skip to content

[CMake] enable CMP0147 policy if available #109150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[CMake] enable CMP0147 policy if available #109150

merged 2 commits into from
Sep 24, 2024

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Sep 18, 2024

Closes #38383.

This enables parallel custom build commands, which improve compilation time on Windows with Visual Studio.

@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Sep 18, 2024
@c8ef
Copy link
Contributor Author

c8ef commented Sep 20, 2024

Hi @RKSimon, could you please take a look at this patch? I'm unsure why the libc++ test is not running, although it functions correctly locally and in the Buildkite CI.

@RKSimon
Copy link
Collaborator

RKSimon commented Sep 20, 2024

I'm not sure either (worked fine for me) - maybe rebase and try again?

@RKSimon
Copy link
Collaborator

RKSimon commented Sep 20, 2024

CC @mstorsjo who might be able to help

@mstorsjo
Copy link
Member

CC @mstorsjo who might be able to help

Sorry, no idea what has happened here - I'd suggest trying to rebase on top of latest main and retrying.

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems reasonable to me. AFAIK we have little to no CI setups that would use MSVC with visual studio generators anyway, they all use ninja usually, so any CI errors here should be unrelated failures anyway (and the libc++ CI is having issues lately).

@c8ef
Copy link
Contributor Author

c8ef commented Sep 24, 2024

Thank you for your review. The patch works well on my Windows machine.
By the way, if this patch is good to go, could you merge it for me?

@RKSimon
Copy link
Collaborator

RKSimon commented Sep 24, 2024

Thank you @c8ef

@mstorsjo
Copy link
Member

Thank you for your review. The patch works well on my Windows machine. By the way, if this patch is good to go, could you merge it for me?

Sure, will do. I kind of intentionally left the PR unmerged for a little while, after accepting, to give people in other time zones another chance to chime in on it, before merging - but I'll merge it now.

@mstorsjo mstorsjo merged commit cf9fc5e into llvm:main Sep 24, 2024
8 of 11 checks passed
@c8ef c8ef deleted the patch-2 branch September 24, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Build system in general and CMake in particular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Visual Studio] Add support for Parallel Custom Build Tools
4 participants