[SandboxIR] Add ExtractValueInst. #106613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackito
requested review from
aeubanks,
vporpo,
alinas,
tmsri,
tschuett and
Sterling-Augustine
vporpo
reviewed
Aug 29, 2024
| return From->getSubclassID() == ClassID::ExtractValue; | ||
| } | ||
|
|
||
| static Type *getIndexedType(Type *Agg, ArrayRef<unsigned> Idxs) { |
There was a problem hiding this comment.
nit: It is not straight forward what this function does, so I would copy LLVM IR's comments.
| EXPECT_EQ(sandboxir::ExtractValueInst::getIndexedType( | ||
| AggType, ArrayRef<unsigned>({1, 0})), | ||
| llvm::ExtractValueInst::getIndexedType(AggType, | ||
| ArrayRef<unsigned>({1, 0}))); |
There was a problem hiding this comment.
Could you have two checks for getIndexedType(), one that returns non-null and one that returns null. The reason is that once we migrate to sandboxir::Type the null case would need special treatment.
There was a problem hiding this comment.
Added a simple test for the nullptr case. Please take another look.
- Copy comment from llvm::ExtractValueInst::getIndexedType - Add test case for getIndexedType returning nullptr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.