Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR][OpenMP] Handle privatization for global values in MLIR->LLVM translation #104407

Merged
merged 1 commit into from
Aug 26, 2024

Commits on Aug 26, 2024

  1. [MLIR][OpenMP] Handle privatization for global values in MLIR->LLVM t…

    …ranslation
    
    Fix for llvm#102939.
    
    The issues occurs because the CodeExtractor component only collect inputs
    (to the parallel regions) that are defined in the same function in which the
    parallel regions is present. Howerver, this is problematic because if we are
    privatizing a global value (e.g. a `target` variable which is emitted as a
    global), then we miss finding that input and we do not privatize the
    variable.
    
    This commit attempts to fix the issue by adding a flag to the
    CodeExtractor so that we can collect global inputs.
    ergawy committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    66c94ea View commit details
    Browse the repository at this point in the history