[flang][test] Restrict Evaluate/fold-out_of_range.f90 to x86_64 #102890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Flang :: Evaluate/fold-out_of_range.f90` currently `FAIL`s on Linux/sparc64. This seems to be the same issue that led to disabling the test on Solaris in 27549ee. In fact, the generic Solaris disablement was over-eager: the test `PASS`es just fine on Solaris/amd64. To fix this, this patch disables the test on sparc only, at the same time simplifying the `target=` clauses. Tested on `sparc64-unknown-linux-gnu`, `sparcv9-sun-solaris2.11`, `amd64-pc-solaris2.11`, and `x86_64-pc-linux-gnu`.
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-semantics Author: Rainer Orth (rorth) Changes
To fix this, this patch disables the test on sparc only, at the same time simplifying the Tested on Full diff: https://github.com/llvm/llvm-project/pull/102890.diff 1 Files Affected:
diff --git a/flang/test/Evaluate/fold-out_of_range.f90 b/flang/test/Evaluate/fold-out_of_range.f90
index 81551255135d2f..6fb3d072bb2301 100644
--- a/flang/test/Evaluate/fold-out_of_range.f90
+++ b/flang/test/Evaluate/fold-out_of_range.f90
@@ -1,5 +1,5 @@
! RUN: %python %S/test_folding.py %s %flang_fc1 -pedantic
-! UNSUPPORTED: target=powerpc{{.*}}, target=aarch{{.*}}, target=arm{{.*}}, system-windows, system-solaris
+! UNSUPPORTED: target={{(arm|aarch64|powerpc|sparc).*}}, system-windows
! Tests folding of OUT_OF_RANGE().
module m
integer(1), parameter :: i1v(*) = [ -huge(1_1) - 1_1, huge(1_1) ]
|
luporl
reviewed
Aug 12, 2024
luporl
approved these changes
Aug 13, 2024
rorth
changed the title
rorth
added a commit
to rorth/llvm-project
that referenced
this pull request
Aug 14, 2024
`Flang :: Semantics/kinds04_q10.f90` `FAIL`s on SPARC, both Solaris/sparcv9 and Linux/sparc64: ``` actual at 16: invalid argument on REAL(10) to REAL(4) conversion actual at 20: invalid argument on REAL(10) to REAL(4) conversion actual at 24: invalid argument on REAL(10) to REAL(4) conversion actual at 31: invalid argument on REAL(10) to REAL(8) conversion actual at 37: invalid argument on REAL(10) to REAL(8) conversion ``` This seems to be the same issue recently seen in PR llvm#102890: even though the target in question supports `REAL(10)`, the host does not. Therefore this patch restricts the test to `x86_64`. Tested on `sparcv9-sun-solaris2.11`, `sparc64-unknown-linux-gnu`, `amd64-pc-solaris2.11`, and `x86_64-pc-linux-gnu`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flang :: Evaluate/fold-out_of_range.f90currentlyFAILs on Linux/sparc64. This seems to be the same issue that led to disabling the test on Solaris in 27549ee. In fact, the generic Solaris disablement was over-eager: the testPASSes just fine on Solaris/amd64.Since the use of
REAL*10makes the test x86-specific, this patch actually implements that requirement.Tested on
sparc64-unknown-linux-gnu,sparcv9-sun-solaris2.11,amd64-pc-solaris2.11, andx86_64-pc-linux-gnu.