-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DAG] extractShiftForRotate - Assertion `(OppShift.getOpcode() == ISD::SHL || OppShift.getOpcode() == ISD::SRL) && "Existing shift must be valid as a rotate half" #57474
Comments
CC @DataCorrupted - carrying on #57283 here in case we want to cherry pick it |
… an early-out We feed the result from the first extractShiftForRotate call into the second, and that result might no longer be a shift op (usually due to constant folding). NOTE: We REALLY need to stop creating nodes on the fly inside extractShiftForRotate! Fixes Issue #57474
@tru Probably leave this until 15.0.1 - is it possible to set up the cherry pick now or do we have to wait until 15.0.0 has released? |
You can do it now. Should be fine ! |
/cherry-pick eaede4b |
Error: Command failed due to missing milestone. |
Oops - my bad. I hadn't added the right metadata for that milestone- but I fixed it now so you could try again. |
/cherry-pick eaede4b |
/branch llvm/llvm-project-release-prs/issue57474 |
/pull-request llvm/llvm-project-release-prs#138 |
… an early-out We feed the result from the first extractShiftForRotate call into the second, and that result might no longer be a shift op (usually due to constant folding). NOTE: We REALLY need to stop creating nodes on the fly inside extractShiftForRotate! Fixes Issue #57474 (cherry picked from commit eaede4b)
Pulled out of #57283
The text was updated successfully, but these errors were encountered: