clang-format sorts includes even in files where it should be disabled completely

[llvmbot]

Bugzilla Link	27042
Version	11.0
OS	All
Reporter	LLVM Bugzilla Contributor
CC	@mydeveloperday,@ptomato

Extended Description

I have the following settings for third-party code:

---

DisableFormat: true
...

clang-format 3.8.0 ignores this option and still sorts includes, although it's expected to be disabled completely and that it won't change files with the above settings.

Now I have to explicitly disable sorting to workaround this issue.

---

DisableFormat: true
SortIncludes: false
...

[ptomato]

Confirmed on clang-format 11.0.0:

formatbug.js:

import b from './b.js';

import a from './a.js';

console.log('Hello world!');

Reproduce with clang-format --style='{Language: JavaScript, DisableFormat: true}' formatbug.js

[mydeveloperday]

Can I ask, what is the purpose of running ClangFormat with DisableFormat:false?

[ptomato]

Can I ask, what is the purpose of running ClangFormat with
DisableFormat:false?

The OP suggested it as a setting for third-party code. In my case it's because I automatically run clang-format-diff as a git commit hook. My codebase has both JS and C++ code, and I only want clang-format to format the C++ code, so I disable clang-format for JS code.

[mydeveloperday]

Is there a situation where one might want to do?

---

DisableFormat: true
SortIncludes: true

I guess the question is... if we move SortIncludes into DisableFormat then what does

DisableFormat: false
SortIncludes: true

Actually do?

Also then Without testing it, I'm also not sure what would do:

SortIncludes: true
DisableFormat: false

I'm not averse to such a change, I think we just need to be clear what it means.

[mydeveloperday]

This issue was resolved by 61dc0f2

which closed #34447 making this issue a duplicate

[DaanDeMeyer]

@mydeveloperday This is rather unfortunate as it prevents using clang-format only for include sorting and nothing else. Any suggestions on how to make clang-format work for only include sorting again without doing any other formatting?