Ubuntu Jammy: fails to build with "--lto-CGO2: unknown option"

[sylvestre]

With gold as linker:

FAILED: /build/source/build-llvm/tools/clang/stage2-bins/lib/libomptarget-amdgpu.bc 
: && /build/source/build-llvm/tools/clang/stage2-bins/./bin/clang++ --target=x86_64-pc-linux-gnu -fstack-protector-strong -Wformat -Werror=format-security -Wno-unused-command-line-argument -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -ffile-prefix-map=/build/source/build-llvm/tools/clang/stage2-bins/runtimes/runtimes-bins=../../../../../../ -ffile-prefix-map=/build/source/= -no-canonical-prefixes -O2 -DNDEBUG -g1 -Wl,-z,relro -Wl,--build-id -L/build/source/build-llvm/lib -fuse-ld=gold    --target=amdgcn-amd-amdhsa -r -nostdlib -flto -Wl,--lto-emit-llvm -march= offload/DeviceRTL/Allocator.cpp-amdgpu.o offload/DeviceRTL/Configuration.cpp-amdgpu.o offload/DeviceRTL/Debug.cpp-amdgpu.o offload/DeviceRTL/Kernel.cpp-amdgpu.o offload/DeviceRTL/LibC.cpp-amdgpu.o offload/DeviceRTL/Mapping.cpp-amdgpu.o offload/DeviceRTL/Misc.cpp-amdgpu.o offload/DeviceRTL/Parallelism.cpp-amdgpu.o offload/DeviceRTL/Profiling.cpp-amdgpu.o offload/DeviceRTL/Reduction.cpp-amdgpu.o offload/DeviceRTL/State.cpp-amdgpu.o offload/DeviceRTL/Synchronization.cpp-amdgpu.o offload/DeviceRTL/Tasking.cpp-amdgpu.o offload/DeviceRTL/DeviceUtils.cpp-amdgpu.o offload/DeviceRTL/Workshare.cpp-amdgpu.o -o /build/source/build-llvm/tools/clang/stage2-bins/lib/libomptarget-amdgpu.bc   && :
/usr/bin/ld.gold: --lto-CGO2: unknown option
/usr/bin/ld.gold: use the --help option for usage information
clang++: error: ld.lld command failed with exit code 1 (use -v to see invocation)

full log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-jammy-binaries/architecture=amd64,distribution=jammy,label=amd64/2077/consoleFull

2b002d6 built fine
I guess it has been caused by #136197
cc @BertalanD @sbc100

[BertalanD]

I don't see how my change could have caused it. The change is a simple bug fix for wasm-ld, it should not impact the gold linker plugin. Can you bisect it please?

[sylvestre]

The range is:
2b002d6..7f41095

maybe it is #126143 from @jhuber6

[jhuber6]

Yeah it's most likely that patch. I'm going to guess that passing -fuse-ld=gold is screwing with it, since AMDGPU can only use ld.lld. I could override that for a quick fix.

[sylvestre]

@jhuber6 yeah, it would be nice if you could fix it :) thanks