Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT][AArch64] The implementation of MCF algorithms in BOLT #112085

Open
CHNRyan opened this issue Oct 12, 2024 · 1 comment
Open

[BOLT][AArch64] The implementation of MCF algorithms in BOLT #112085

CHNRyan opened this issue Oct 12, 2024 · 1 comment
Labels
BOLT question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!

Comments

@CHNRyan
Copy link

CHNRyan commented Oct 12, 2024

Hi,

I’m looking to contribute to BOLT by enhancing the accuracy of edge weight estimation for the AArch64 and RISC-V platforms. This improvement would help us obtain more accurate edge weight information in these architectures. Some research papers, such as Profile Inference Revisited and Completing Incomplete Edge Profiles by Applying Minimum Cost Circulation Algorithms, propose using min-cost flow algorithms to address this issue. However, I noticed that this approach hasn’t been implemented in BOLT, and remnants of it were recently removed (#93065).

Could you provide insights into why this approach was disabled in BOLT? Was the estimated overhead of the method too high, or were the existing data structures in BOLT insufficient to support such methods? What are the main challenges and issues in implementing this solution in BOLT?

Thank you in advance for your opinions.

@github-actions github-actions bot added the BOLT label Oct 12, 2024
@maksfb
Copy link
Contributor

maksfb commented Oct 13, 2024

@rafaelauler experimented with MCF when edge profile wasn't available on AArch64. IIRC, the overhead was high and we couldn't close the performance gap with edge profiling.

@asl asl added the question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead! label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BOLT question A question, not bug report. Check out https://llvm.org/docs/GettingInvolved.html instead!
Projects
None yet
Development

No branches or pull requests

3 participants