-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMDGPU should implement IR version of isFMAFasterThanFMulAndFAdd #108751
Comments
Hi! This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below. |
@llvm/issue-subscribers-good-first-issue Author: Matt Arsenault (arsenm)
TargetLowering has an IR variant of [isFMAFasterThanFMulAndFAdd](https://github.com/llvm/llvm-project/blob/3ae71d154e5dfb5e5a5d27b3699b27ce2b55f44d/llvm/include/llvm/CodeGen/TargetLowering.h#L3262), and AMDGPU does not yet implement it.
As far as I can tell, this is only ever used in target code to implement isProfitableToHoist (e.g. AArch64 here https://github.com/llvm/llvm-project/blob/3ae71d154e5dfb5e5a5d27b3699b27ce2b55f44d/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp#L16086) So for this to be effective, isProfitableToHoist would also need to be implemented similarly. |
@llvm/issue-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm)
TargetLowering has an IR variant of [isFMAFasterThanFMulAndFAdd](https://github.com/llvm/llvm-project/blob/3ae71d154e5dfb5e5a5d27b3699b27ce2b55f44d/llvm/include/llvm/CodeGen/TargetLowering.h#L3262), and AMDGPU does not yet implement it.
As far as I can tell, this is only ever used in target code to implement isProfitableToHoist (e.g. AArch64 here https://github.com/llvm/llvm-project/blob/3ae71d154e5dfb5e5a5d27b3699b27ce2b55f44d/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp#L16086) So for this to be effective, isProfitableToHoist would also need to be implemented similarly. |
TargetLowering has an IR variant of isFMAFasterThanFMulAndFAdd, and AMDGPU does not yet implement it.
As far as I can tell, this is only ever used in target code to implement isProfitableToHoist (e.g. AArch64 here https://github.com/llvm/llvm-project/blob/3ae71d154e5dfb5e5a5d27b3699b27ce2b55f44d/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp#L16086)
So for this to be effective, isProfitableToHoist would also need to be implemented similarly.
The text was updated successfully, but these errors were encountered: