[clang-format] Spacing with function pointer

[prj-]

I'm not sure the spacing surrounding & is intentional or not?

$ clang-format func.c
int main(int argc, char *argv) {
  func((void *)&a);
  func((void (**)(void)) & b);
  return 0;
}

[prj-]

This happens with both clang-format version 18 and version 20. If this is something that needs fixing, any hope that it gets ported to version 19 as well?

[prj-]

@owenca, this is broken again. Works OK with version 19.1.0, but with Debian clang-format version 20.0.0 (++20240917111146+1e23a6142a82-1~exp1~20240917111312.2342), I get:

$ clang-format foobar.c
int main() {
  if (type == NON_UNIFORM)
    return (PetscErrorCode(*)(void *, void *, PetscInt,
                              ...))&PCTFS_rvec_non_uniform;
  return 0;
}
$ clang-format-20 foobar.c 
int main() {
  if (type == NON_UNIFORM)
    return (PetscErrorCode(*)(void *, void *, PetscInt, ...)) &
           PCTFS_rvec_non_uniform;
  return 0;
}

It was OK with 20240831100704%2B8aa8c0590c09-1~exp1~20240831220720.2307.

[owenca]

It seems the root cause is that the l_paren in (*) is not annotated as FunctionTypeLParen. Can you open an issue for this, @prj-?

[prj-]

I will do it no problem.

[prj-]

Cross-referencing #109146.