Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: llvm/llvm-project
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: llvm/llvm-project
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: users/tblah/openmp-parse-errors-1
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Aug 21, 2025

  1. [flang][OpenMP] move omp end directive validation to semantics 

    The old parse tree errors quckly exploded to thousands of unhelpful
lines when there were multiple missing end directives (e.g. #90452).

Instead I've added a flag to the parse tree indicating when a missing
end directive needs to be diagnosed, and moved the error messages to
semantics (where they are a lot easier to control).

This has the disadvantage of not displaying the error if there were
other parse errors, but there is a precedent for this approach (e.g.
parsing atomic constructs).
    @tblah
    tblah committed Aug 21, 2025
    Configuration menu
    Copy the full SHA
    040a19d View commit details
    Browse the repository at this point in the history

  2. Check for loosely-strictured block instead of maintaining a flag

    @tblah
    tblah committed Aug 21, 2025
    Configuration menu
    Copy the full SHA
    16662ce View commit details
    Browse the repository at this point in the history
Loading