Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: llvm/llvm-project
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: llvm/llvm-project
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: users/hekota/pr152452-resource-array-impl-binding-attr
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Aug 7, 2025

  1. [HLSL] Add isHLSLResourceRecordArray method to clang::Type

    @hekota
    hekota committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    10a06e3 View commit details
    Browse the repository at this point in the history

  2. [HLSL] Add implicit binding attribute to resource arrays without bind… 

    …ing and make them static

If a resource array does not have an explicit binding attribute, SemaHLSL will add
an implicit one. The attribute will be used to transfer implicit binding order ID
to the codegen, the same way as it is done for HLSLBufferDecls. This is necessary
in order to generate correct initialization of resources in an array that does not
have an explicit binding.

This change also marks resource arrays declared at a global scope as `static`, which
is what is already done for standalone resources.
    @hekota
    hekota committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    4e153a4 View commit details
    Browse the repository at this point in the history

  3. one more instance to replace

    @hekota
    hekota committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    ac99f5a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'users/hekota/pr152450-add-is-record-array-to-type' into… 

    … resource-array-impl-binding-attr
    @hekota
    hekota committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    b5ca61c View commit details
    Browse the repository at this point in the history

  5. update test

    @hekota
    hekota committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    e12a7a9 View commit details
    Browse the repository at this point in the history
Loading