Skip to content

Commit ed61123

Browse files
authored
[libc++] tests with picolibc: handle stdin (#74712)
Add proper explanation for cin.sh.cpp fail. The stdin-is-piped.sh.cpp used to fail with old qemu (4.2.0), but should pass now, as the qemu is updated now to 8.1.3 in CI.
1 parent 52fe16a commit ed61123

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

libcxx/test/libcxx/selftest/stdin-is-piped.sh.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
// Make sure that the executor pipes standard input to the test-executable being run.
1010

11-
// XFAIL: LIBCXX-PICOLIBC-FIXME
12-
1311
// RUN: %{build}
1412
// RUN: echo "abc" | %{exec} %t.exe
1513

libcxx/test/std/input.output/iostream.objects/narrow.stream.objects/cin.sh.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,11 @@
88

99
// TODO: Investigate
1010
// UNSUPPORTED: LIBCXX-AIX-FIXME
11-
// XFAIL: LIBCXX-PICOLIBC-FIXME
11+
12+
// QEMU does not detect EOF, when reading from stdin
13+
// "echo -n" suppresses any characters after the output and so the test hangs.
14+
// https://gitlab.com/qemu-project/qemu/-/issues/1963
15+
// UNSUPPORTED: LIBCXX-PICOLIBC-FIXME
1216

1317
// This test hangs on Android devices that lack shell_v2, which was added in
1418
// Android N (API 24).

0 commit comments

Comments
 (0)