Skip to content

Commit ebefad2

Browse files
committed
tailenders
Signed-off-by: James Newling <james.newling@gmail.com>
1 parent 847ce96 commit ebefad2

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2383,26 +2383,26 @@ PPCIntrinsicLibrary::genVecSplat(mlir::Type resultType,
23832383
auto context{builder.getContext()};
23842384
auto argBases{getBasesForArgs(args)};
23852385

2386-
mlir::vector::SplatOp splatOp{nullptr};
2386+
mlir::vector::BroadcastOp splatOp{nullptr};
23872387
mlir::Type retTy{nullptr};
23882388
switch (vop) {
23892389
case VecOp::Splat: {
23902390
assert(args.size() == 2);
23912391
auto vecTyInfo{getVecTypeFromFir(argBases[0])};
23922392

23932393
auto extractOp{genVecExtract(resultType, args)};
2394-
splatOp =
2395-
mlir::vector::SplatOp::create(builder, loc, *(extractOp.getUnboxed()),
2396-
vecTyInfo.toMlirVectorType(context));
2394+
splatOp = mlir::vector::BroadcastOp::create(
2395+
builder, loc, vecTyInfo.toMlirVectorType(context),
2396+
*(extractOp.getUnboxed()));
23972397
retTy = vecTyInfo.toFirVectorType();
23982398
break;
23992399
}
24002400
case VecOp::Splats: {
24012401
assert(args.size() == 1);
24022402
auto vecTyInfo{getVecTypeFromEle(argBases[0])};
24032403

2404-
splatOp = mlir::vector::SplatOp::create(
2405-
builder, loc, argBases[0], vecTyInfo.toMlirVectorType(context));
2404+
splatOp = mlir::vector::BroadcastOp::create(
2405+
builder, loc, vecTyInfo.toMlirVectorType(context), argBases[0]);
24062406
retTy = vecTyInfo.toFirVectorType();
24072407
break;
24082408
}
@@ -2412,8 +2412,8 @@ PPCIntrinsicLibrary::genVecSplat(mlir::Type resultType,
24122412
auto intOp{builder.createConvert(loc, eleTy, argBases[0])};
24132413

24142414
// the intrinsic always returns vector(integer(4))
2415-
splatOp = mlir::vector::SplatOp::create(builder, loc, intOp,
2416-
mlir::VectorType::get(4, eleTy));
2415+
splatOp = mlir::vector::BroadcastOp::create(
2416+
builder, loc, mlir::VectorType::get(4, eleTy), intOp);
24172417
retTy = fir::VectorType::get(4, eleTy);
24182418
break;
24192419
}
@@ -2444,7 +2444,8 @@ PPCIntrinsicLibrary::genVecXlds(mlir::Type resultType,
24442444
auto addrConv{fir::ConvertOp::create(builder, loc, i64RefTy, addr)};
24452445

24462446
auto addrVal{fir::LoadOp::create(builder, loc, addrConv)};
2447-
auto splatRes{mlir::vector::SplatOp::create(builder, loc, addrVal, i64VecTy)};
2447+
auto splatRes{
2448+
mlir::vector::BroadcastOp::create(builder, loc, i64VecTy, addrVal)};
24482449

24492450
mlir::Value result{nullptr};
24502451
if (mlirTy != splatRes.getType()) {

mlir/docs/Dialects/Vector.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,6 @@ infrastructure can apply iteratively.
176176
### Virtual Vector to Hardware Vector Lowering
177177

178178
For now, `VV -> HWV` are specified in C++ (see for instance the
179-
[SplatOpLowering for n-D vectors](https://github.com/tensorflow/mlir/commit/0a0c4867c6a6fcb0a2f17ef26a791c1d551fe33d)
180-
or the
181179
[VectorOuterProductOp lowering](https://github.com/tensorflow/mlir/commit/957b1ca9680b4aacabb3a480fbc4ebd2506334b8)).
182180

183181
Simple

0 commit comments

Comments
 (0)