Skip to content

Commit ea64047

Browse files
committed
Revert "[llvm] Disable HandleLLVMOptions in runtimes mode (#73031)"
This appears to have caused a variety of breakages, see comments on the PR. > Summary: > There are a few default options that LLVM adds that can be problematic > for runtimes builds. These options are generally intended to handle > building LLVM itself, but are also added when building in a runtimes > mode. One such issue I've run into is that in `libc` we deliberately use > `--target` to use a different device toolchain, which doesn't support > some linker arguments passed via `-Wl`. This is observed in > #73030 when attempting to use > these options. > > This patch completely removes these default arguments. > > The consensus is that any issues created by this patch should ultimately > be solved on a per-runtime basis. This reverts commit ee922e6.
1 parent 2a8040e commit ea64047

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

runtimes/CMakeLists.txt

+2
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,9 @@ endif()
151151
# Avoid checking whether the compiler is working.
152152
set(LLVM_COMPILER_CHECKED ON)
153153

154+
# Handle common options used by all runtimes.
154155
include(AddLLVM)
156+
include(HandleLLVMOptions)
155157

156158
find_package(Python3 REQUIRED COMPONENTS Interpreter)
157159

0 commit comments

Comments
 (0)