Skip to content

Commit

Permalink
[polly] Fixed a number of typos. NFC
Browse files Browse the repository at this point in the history
I went over the output of the following mess of a command:

`(ulimit -m 2000000; ulimit -v 2000000; git ls-files -z | parallel --xargs -0 cat | aspell list --mode=none --ignore-case | grep -E '^[A-Za-z][a-z]*$' | sort | uniq -c | sort -n | grep -vE '.{25}' | aspell pipe -W3 | grep : | cut -d' ' -f2 | less)`

and proceeded to spend a few days looking at it to find probable typos
and fixed a few hundred of them in all of the llvm project (note, the
ones I found are not anywhere near all of them, but it seems like a
good start).

Reviewed By: inclyc

Differential Revision: https://reviews.llvm.org/D131167
  • Loading branch information
GabrielRavier authored and inclyc committed Aug 7, 2022
1 parent 82439b2 commit ea540bc
Show file tree
Hide file tree
Showing 27 changed files with 33 additions and 33 deletions.
2 changes: 1 addition & 1 deletion polly/docs/HowToManuallyUseTheIndividualPiecesOfPolly.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ performance improvement can be expected by an optimal automatic optimizer.

Polly is only able to work with code that matches a canonical form.
To translate the LLVM-IR into this form we use a set of
canonicalication passes. They are scheduled by using
canonicalization passes. They are scheduled by using
'-polly-canonicalize'.

.. code-block:: console
Expand Down
2 changes: 1 addition & 1 deletion polly/include/polly/Support/VirtualInstruction.h
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class VirtualUse final {
/// @param U The llvm::Use the get information for.
/// @param LI The LoopInfo analysis. Needed to determine whether the
/// value is synthesizable.
/// @param Virtual Whether to ignore existing MemoryAcccess.
/// @param Virtual Whether to ignore existing MemoryAccess.
///
/// @return The VirtualUse representing the same use as @p U.
static VirtualUse create(Scop *S, const Use &U, LoopInfo *LI, bool Virtual);
Expand Down
2 changes: 1 addition & 1 deletion polly/lib/CodeGen/ManagedMemoryRewrite.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ static void rewriteOldValToNew(Instruction *Inst, Value *OldVal, Value *NewVal,
// in an expression.
// We need this auxiliary function, because if we have a
// `Constant` that is a user of `V`, we need to recurse into the
// `Constant`s uses to gather the root instruciton.
// `Constant`s uses to gather the root instruction.
static void getInstructionUsersOfValue(Value *V,
SmallVector<Instruction *, 4> &Owners) {
if (auto *I = dyn_cast<Instruction>(V)) {
Expand Down
2 changes: 1 addition & 1 deletion polly/lib/Transform/ManualOptimizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class SearchTransformVisitor final
}

// If illegal, revert and remove the transformation to not risk re-trying
// indefintely.
// indefinitely.
MDNode *NewLoopMD =
makePostTransformationMetadata(Ctx, LoopMD, {TransPrefix}, {});
BandAttr *Attr = getBandAttr(OrigBand);
Expand Down
2 changes: 1 addition & 1 deletion polly/lib/Transform/ScheduleTreeTransform.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ class BandCollapseRewriter final

// Do not merge permutable band to avoid loosing the permutability property.
// Cannot collapse even two permutable loops, they might be permutable
// individually, but not necassarily accross.
// individually, but not necassarily across.
if (unsignedFromIslSize(Band.n_member()) > 1u && Band.permutable())
return getBase().visitBand(Band);

Expand Down
2 changes: 1 addition & 1 deletion polly/test/CodeGen/non-affine-update.ll
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
; }
; }

; Verify that all changed memory access functions are corectly code generated.
; Verify that all changed memory access functions are correctly code generated.
; At some point this did not work due to memory access identifiers not being
; unique within non-affine scop statements.

Expand Down
2 changes: 1 addition & 1 deletion polly/test/ForwardOpTree/changed-kind.ll
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; Thus, in order to save a scalar dependency, forward-optree replaces
; the use of %0 in Stmt_lor_end93 by a load from @c by changing the
; access find from a scalar access to a array accesses.
; llvm.org/PR48034 decribes a crash caused by the mid-processing change.
; llvm.org/PR48034 describes a crash caused by the mid-processing change.

target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
Expand Down
2 changes: 1 addition & 1 deletion polly/test/ScopDetect/non-affine-loop.ll
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
;
; This function/region does contain a loop, however it is non-affine, hence the access
; A[i] is also. Furthermore, it is the only loop, thus when we over approximate
; non-affine loops __and__ accesses __and__ allow regins without a (affine) loop we will
; non-affine loops __and__ accesses __and__ allow regions without a (affine) loop we will
; detect it, otherwise we won't.
;
; void f(int *A) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
; The loads are currently just adds %7 to the list of required invariant loads
; and only -polly-scops checks whether it is actionally possible the be load
; hoisted. The SCoP is still rejected by -polly-detect because it may alias
; with %A and is not considered to be eligble for runtime alias checking.
; with %A and is not considered to be eligible for runtime alias checking.

; CHECK: remark: ReportVariantBasePtr01.c:6:8: The following errors keep this region from being a Scop.
; CHECK: remark: ReportVariantBasePtr01.c:7:5: Accesses to the arrays "A", " <unknown> " may access the same memory.
Expand Down
2 changes: 1 addition & 1 deletion polly/test/ScopInfo/aliasing_conditional_alias_groups_2.ll
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
; RUN: opt %loadPolly -polly-print-scops -disable-output < %s | FileCheck %s
;
; Check that we create two alias groups since the mininmal/maximal accesses
; Check that we create two alias groups since the minimal/maximal accesses
; depend on %b.
;
; CHECK: Alias Groups (2):
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
; RUN: opt %loadPolly -polly-analysis-computeout=0 -polly-print-scops -polly-rtc-max-parameters=8 -disable-output < %s | FileCheck %s --check-prefix=MAX8
; RUN: opt %loadPolly -polly-analysis-computeout=0 -polly-print-scops -polly-rtc-max-parameters=7 -disable-output < %s | FileCheck %s --check-prefix=MAX7
;
; Check that we allow this SCoP even though it has 10 parameters involved in posisbly aliasing accesses.
; Check that we allow this SCoP even though it has 10 parameters involved in possibly aliasing accesses.
; However, only 7 are involved in accesses through B, 8 through C and none in accesses through A.
;
; MAX8-LABEL: Function: jd
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
;
; which introduced a new parameter (-1 + %b) * %a which was not registered
; correctly and consequently caused a crash due to an expression not being
; regiustered as a parameter.
; registered as a parameter.

target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
; RUN: opt %loadPolly -polly-print-scops -disable-output < %s
;
; This crased at some point as we place %1 and %4 in the same equivalence class
; This crashed at some point as we place %1 and %4 in the same equivalence class
; for invariant loads and when we remap SCEVs to use %4 instead of %1 AddRec SCEVs
; for the for.body.10 loop caused a crash as their operands were not invariant
; in the loop. While we know they are, ScalarEvolution does not. However, we can simply
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

; Verify that we canonicalize accesses even tough one of the accesses (even
; the canonical base) has a partial execution context. This is correct as
; the combined execution context still coveres both accesses.
; the combined execution context still covers both accesses.

; CHECK: Invariant Accesses: {
; CHECK-NEXT: ReadAccess := [Reduction Type: NONE] [Scalar: 0]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
; RUN: | FileCheck %s

; Verify that a delinearized and a not delinearized access are not
; canonizalized.
; canonicalized.

; CHECK: Stmt_body1
; CHECK-NEXT: Domain :=
Expand Down
2 changes: 1 addition & 1 deletion polly/test/ScopInfo/multidim_fold_constant_dim_zero.ll
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
; This test case at some point crashed Polly due to a 'division by zero'
; when trying to fold the constant dimension into outer dimension.
; We verify that this scop is detected without crash. We also test the
; output to undertand that the scop has been analyzed, but has also been
; output to understand that the scop has been analyzed, but has also been
; invalidated due to the zero size dimension.

; CHECK: Assumed Context:
Expand Down
2 changes: 1 addition & 1 deletion polly/test/ScopInfo/multidim_many_references.ll
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
; m->rows, m->cols and m->deps happen before the scop.

; This test case verifies that the construction of the assumed context finishes
; successfully. Depending on how constraineds are accummulated in the assumed
; successfully. Depending on how constrained are accumulated in the assumed
; context, this test case can take even for a smaller number of arrays over a
; minute to complete. With the unrolling choosen in this test, an inefficient
; formulation of the assumption tracking cause LLVM to crash due to excessive
Expand Down
2 changes: 1 addition & 1 deletion polly/test/ScopInfo/ranged_parameter.ll
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
; RUN: opt %loadPolly -polly-print-scops -disable-output < %s | FileCheck %s
;
; Check that the contstraints on the paramater derived from the
; Check that the constraints on the parameter derived from the
; range metadata (see bottom of the file) are present:
;
; CHECK: Context:
Expand Down
2 changes: 1 addition & 1 deletion polly/test/ScopInfo/redundant_parameter_constraint.ll
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
; RUN: opt %loadPolly -polly-print-scops -disable-output < %s | FileCheck %s
;
; The constraint that r2 has to be bigger than r1 is implicitly containted in
; The constraint that r2 has to be bigger than r1 is implicitly contained in
; the domain, hence we do not want to see it explicitly.
;
; CHECK-NOT: r2 >= 1 + r1
Expand Down
2 changes: 1 addition & 1 deletion polly/test/ScopInfo/scalar_to_array.ll
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f3

@A = common global [1024 x float] zeroinitializer, align 8

; Terminating loops without side-effects will be optimzied away, hence
; Terminating loops without side-effects will be optimized away, hence
; detecting a scop would be pointless.
; CHECK-NOT: Function: empty
; Function Attrs: nounwind
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; %tmp4, it is an "external use".
;
; A common mistake is to assume that %tmp5 is used by %tmp4 in bb3, when
; practially it's the incoming block %bb9 which is the user.
; practically it's the incoming block %bb9 which is the user.
;
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"

Expand Down
2 changes: 1 addition & 1 deletion polly/tools/GPURuntime/GPUJIT.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include "stddef.h"

/*
* The following demostrates how we can use the GPURuntime library to
* The following demonstrates how we can use the GPURuntime library to
* execute a GPU kernel.
*
* char KernelString[] = "\n\
Expand Down
2 changes: 1 addition & 1 deletion polly/www/documentation/gpgpucodegen.html
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ <h2>TODO List</h2>
</tr>
<tr>
<th align="left">llvm.codegen Intrinsic Implementation</th>
<td align="center" class='inprogress'>Codeing Finished, To Be Reviewed</td>
<td align="center" class='inprogress'>Coding Finished, To Be Reviewed</td>
<td></td>
</tr>
<tr>
Expand Down
8 changes: 4 additions & 4 deletions polly/www/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ <h4>AST Generation Paper published in TOPLAS</h4>
mappings are lowered to efficient C/LLVM code.
<li><b>User-defined constraint sets for run-time checks</b> We discuss how
arbitrary sets of constraints can be used to automatically create run-time
checks that ensure a set of constrainst actually hold. This feature is
checks that ensure a set of constraints actually hold. This feature is
very useful to verify at run-time various assumptions that have been taken
program optimization.
</ul>
Expand Down Expand Up @@ -142,7 +142,7 @@ <h4>Polly drops the support of ScopLib and the external optimizer PoCC</h4>
The support for ScopLib as an exchange format has been removed as recent
versions of clan, candl and pluto all support the OpenScop exchange format.

The support of the external optmizer PoCC has been dropped in favor of the
The support of the external optimizer PoCC has been dropped in favor of the
isl optimizer (default) and the still available pluto support.
</td>
</tr>
Expand All @@ -154,7 +154,7 @@ <h4>Polly can be built without GPL licensed software</h4> After Sebastian
and David Peixotto's (both Qualcomm) recent <a
href="https://repo.or.cz/w/isl.git/commit/60703e3ee89b9d5d4d1afb6a3f611292c0884574">commit</a>
to isl, isl's latest development version can be built with imath instead of
GMP. With both CLooG and gmp having become optional, the last obilgatory
GMP. With both CLooG and gmp having become optional, the last obligatory
dependency to GPL licensed software has been removed. Now Polly only depends
on isl (and the included imath), which are both MIT licensed.
</td>
Expand Down Expand Up @@ -377,7 +377,7 @@ <h4>Experimental support for the <b>new isl code generator</b></h4>

<tr><td><b><br>2010</b></td></tr>
<tr>
<td><p> Dezember </p></td>
<td><p> December </p></td>
<td><p>Basic vectorization support </p></td>
</tr>

Expand Down
6 changes: 3 additions & 3 deletions polly/www/performance.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ <h1>Performance</h1>

<p>The results shown were created fully automatically without manual
interaction. We did not yet spend any time to tune the results. Hence
further improvments may be achieved by tuning the code generated by Polly, the
further improvements may be achieved by tuning the code generated by Polly, the
heuristics used by Pluto or by investigating if more code could be optimized.
As Pluto was never used at such a low level, its heuristics are probably
far from perfect. Another area where we expect larger performance improvements
Expand All @@ -35,10 +35,10 @@ <h1>Performance</h1>

<p>The polybench test suite contains computation kernels from linear algebra
routines, stencil computations, image processing and data mining. Polly
recognices the majority of them and is able to show good speedup. However,
recognizes the majority of them and is able to show good speedup. However,
to show similar speedup on larger examples like the SPEC CPU benchmarks Polly
still misses support for integer casts, variable-sized multi-dimensional arrays
and probably several other construts. This support is necessary as such
and probably several other constructs. This support is necessary as such
constructs appear in larger programs, but not in our limited test suite.

<h2> Sequential runs</h2>
Expand Down
2 changes: 1 addition & 1 deletion polly/www/projects.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ <h1>Open Projects</h1>
LLVM Polly keeps here a list of open projects which each of themselves would
be a great contribution to Polly. All of these projects are meant to be self
contained and should take a newcomer around 3-4 months of work. The projects
we propose are all suiteable as <a
we propose are all suitable as <a
href="https://developers.google.com/open-source/gsoc/">Google Summer of
Code</a> projects. In case you are interested in a Google Summer of code
project make sure to reach out via the Polly <a
Expand Down
4 changes: 2 additions & 2 deletions polly/www/todo.html
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ <h3 id="phase4"> Phase 4</h3>
</td></tr>
<tr>
<th align="left">
Pointer Comparisions
Pointer Comparisons
</th><td align="center" class='done'> Done
</td><td> Johannes
</td></tr>
Expand Down Expand Up @@ -447,7 +447,7 @@ <h3 id="phase2"> Phase 2 - First Optimizations and Enhanced User Experience (Fin
February 2012)</h3>
<p>

First optimizations to show the usefullness of Polly and enhance the user
First optimizations to show the usefulness of Polly and enhance the user
experience. We also try to increase the amount of code we can optimize.
</p>
<table class="wikitable" cellpadding="2">
Expand Down

0 comments on commit ea540bc

Please sign in to comment.