review-comment

bjacob · bjacob · commit e8746918a444 · 2024-05-08T12:33:11.000-04:00
diff --git a/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp b/mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
@@ -2358,7 +2358,7 @@ LogicalResult ExpandShapeOp::verify() {
   ArrayRef<int64_t> resShape = getResult().getType().getShape();
   for (auto [pos, shape] : llvm::enumerate(resShape)) {
     if (!ShapedType::isDynamic(shape) && shape != staticOutputShapes[pos]) {
-      emitOpError("invalid output shape provided at pos ") << pos;
+      return emitOpError("invalid output shape provided at pos ") << pos;
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -2358,7 +2358,7 @@ LogicalResult ExpandShapeOp::verify() {`
`2358`	`2358`	`ArrayRef<int64_t> resShape = getResult().getType().getShape();`
`2359`	`2359`	`for (auto [pos, shape] : llvm::enumerate(resShape)) {`
`2360`	`2360`	`if (!ShapedType::isDynamic(shape) && shape != staticOutputShapes[pos]) {`
`2361`		`- emitOpError("invalid output shape provided at pos ") << pos;`
	`2361`	`+ return emitOpError("invalid output shape provided at pos ") << pos;`
`2362`	`2362`	`}`
`2363`	`2363`	`}`
`2364`	`2364`