fix lint warnings and linkage errors

Author: michaelrj-google

libcxx/include/__charconv/from_chars_floating_point.h

@@ -32,10 +32,10 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 #if _LIBCPP_STD_VER >= 17
 
 from_chars_result from_chars_floating_point(
-    const char* __first, const char* __last, float& value, chars_format fmt = chars_format::general);
+    const char* __first, const char* __last, float& __value, chars_format __fmt = chars_format::general);
 
 from_chars_result from_chars_floating_point(
-    const char* __first, const char* __last, double& value, chars_format fmt = chars_format::general);
+    const char* __first, const char* __last, double& __value, chars_format __fmt = chars_format::general);
 
 // template <typename _Tp, __enable_if_t<is_floating_point<_Tp>::value, int> = 0>
 // inline from_chars_result

libcxx/src/charconv.cpp

@@ -75,20 +75,24 @@ to_chars_result to_chars(char* __first, char* __last, long double __value, chars
       __first, __last, static_cast<double>(__value), __fmt, __precision);
 }
 
-from_chars_result from_chars_floating_point(const char* __first, const char* __last, float& value, chars_format fmt) {
-  return from_chars_floating_point<float>(__first, __last, value, fmt);
+from_chars_result
+from_chars_floating_point(const char* __first, const char* __last, float& __value, chars_format __fmt) {
+  return from_chars_floating_point<float>(__first, __last, __value, __fmt);
 }
 
-from_chars_result from_chars_floating_point(const char* __first, const char* __last, double& value, chars_format fmt) {
-  return from_chars_floating_point<double>(__first, __last, value, fmt);
+from_chars_result
+from_chars_floating_point(const char* __first, const char* __last, double& __value, chars_format __fmt) {
+  return from_chars_floating_point<double>(__first, __last, __value, __fmt);
 }
 
-from_chars_result from_chars(const char* __first, const char* __last, float& __value, chars_format fmt) {
-  return std::from_chars_floating_point(__first, __last, __value, fmt);
+_LIBCPP_EXPORTED_FROM_ABI from_chars_result
+from_chars(const char* __first, const char* __last, float& __value, chars_format __fmt) {
+  return from_chars_floating_point(__first, __last, __value, __fmt);
 }
 
-from_chars_result from_chars(const char* __first, const char* __last, double& __value, chars_format fmt) {
-  return std::from_chars_floating_point(__first, __last, __value, fmt);
+_LIBCPP_EXPORTED_FROM_ABI from_chars_result
+from_chars(const char* __first, const char* __last, double& __value, chars_format __fmt) {
+  return from_chars_floating_point(__first, __last, __value, __fmt);
 }
 
 _LIBCPP_END_NAMESPACE_STD

libcxx/src/include/from_chars_floating_point.h

@@ -27,15 +27,15 @@
 _LIBCPP_BEGIN_NAMESPACE_STD
 
 template <typename _Tp, __enable_if_t<std::is_floating_point<_Tp>::value, int> = 0>
-from_chars_result from_chars_floating_point(const char* __first, const char* __last, _Tp& value, chars_format fmt) {
+from_chars_result from_chars_floating_point(const char* __first, const char* __last, _Tp& __value, chars_format __fmt) {
   using _Traits    = _Floating_type_traits<_Tp>;
   using _Uint_type = typename _Traits::_Uint_type;
   ptrdiff_t length = __last - __first;
   _LIBCPP_ASSERT_INTERNAL(length > 0, "");
 
   // hacky parsing code as example. Not intended for actual use. I'm just going to handle the base 10
   // chars_format::general case. Also, no sign, inf, or nan handling.
-  _LIBCPP_ASSERT_INTERNAL(fmt == std::chars_format::general, "");
+  _LIBCPP_ASSERT_INTERNAL(__fmt == std::chars_format::general, "");
 
   const char* src = __first; // rename to match the libc code copied for this section.
 
@@ -126,7 +126,7 @@ from_chars_result from_chars_floating_point(const char* __first, const char* __l
   auto result = LIBC_NAMESPACE::fputil::FPBits<_Tp>();
   result.set_mantissa(expanded_float.mantissa);
   result.set_biased_exponent(expanded_float.exponent);
-  value = result.get_val();
+  __value = result.get_val();
   return {src + index, {}};
 }
 

libcxx/test/std/utilities/charconv/charconv.from.chars/float.pass.cpp

@@ -19,7 +19,7 @@
 
 template <typename T>
 struct test_basics {
-  TEST_CONSTEXPR_CXX23 void operator()() {
+  void operator()() {
     std::from_chars_result r;
     T x;
 
@@ -57,7 +57,7 @@ struct test_basics {
   }
 };
 
-TEST_CONSTEXPR_CXX23 bool test() {
+bool test() {
   run<test_basics>(all_floats);
 
   return true;