Skip to content

Commit c9a5dd8

Browse files
gonzalobggonzalobg
committed
[NVPTX] Cleanup comments in tests
1 parent e36d7c4 commit c9a5dd8

File tree

2 files changed

+45
-127
lines changed

2 files changed

+45
-127
lines changed

‎llvm/test/CodeGen/NVPTX/load-store-sm-70.ll

Lines changed: 10 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ define void @generic_acq_rel(ptr %a, ptr %b, ptr %c, ptr %d, ptr %e) local_unnam
4141
; CHECK: st.release.sys.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
4242
store atomic double %f.add, ptr %e release, align 8
4343

44-
; TODO: LLVM IR Verifier does not support atomics on vector types.
45-
4644
ret void
4745
}
4846

@@ -84,8 +82,6 @@ define void @generic_acq_rel_volatile(ptr %a, ptr %b, ptr %c, ptr %d, ptr %e) lo
8482
; CHECK: st.release.sys.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
8583
store atomic volatile double %f.add, ptr %e release, align 8
8684

87-
; TODO: LLVM IR Verifier does not support atomics on vector types.
88-
8985
ret void
9086
}
9187

@@ -139,8 +135,6 @@ define void @generic_sc(ptr %a, ptr %b, ptr %c, ptr %d, ptr %e) local_unnamed_ad
139135
; CHECK: st.release.sys.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
140136
store atomic double %f.add, ptr %e seq_cst, align 8
141137

142-
; TODO: LLVM IR Verifier does not support atomics on vector types.
143-
144138
ret void
145139
}
146140

@@ -194,8 +188,6 @@ define void @generic_sc_volatile(ptr %a, ptr %b, ptr %c, ptr %d, ptr %e) local_u
194188
; CHECK: st.release.sys.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
195189
store atomic volatile double %f.add, ptr %e seq_cst, align 8
196190

197-
; TODO: LLVM IR Verifier does not support atomics on vector types.
198-
199191
ret void
200192
}
201193

@@ -239,8 +231,6 @@ define void @global_acq_rel(ptr addrspace(1) %a, ptr addrspace(1) %b, ptr addrsp
239231
; CHECK: st.release.sys.global.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
240232
store atomic double %f.add, ptr addrspace(1) %e release, align 8
241233

242-
; TODO: LLVM IR Verifier does not support atomics on vector types.
243-
244234
ret void
245235
}
246236

@@ -282,8 +272,6 @@ define void @global_acq_rel_volatile(ptr addrspace(1) %a, ptr addrspace(1) %b, p
282272
; CHECK: st.release.sys.global.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
283273
store atomic volatile double %f.add, ptr addrspace(1) %e release, align 8
284274

285-
; TODO: LLVM IR Verifier does not support atomics on vector types.
286-
287275
ret void
288276
}
289277

@@ -337,8 +325,6 @@ define void @global_seq_cst(ptr addrspace(1) %a, ptr addrspace(1) %b, ptr addrsp
337325
; CHECK: st.release.sys.global.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
338326
store atomic double %f.add, ptr addrspace(1) %e seq_cst, align 8
339327

340-
; TODO: LLVM IR Verifier does not support atomics on vector types.
341-
342328
ret void
343329
}
344330

@@ -392,8 +378,6 @@ define void @global_seq_cst_volatile(ptr addrspace(1) %a, ptr addrspace(1) %b, p
392378
; CHECK: st.release.sys.global.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
393379
store atomic volatile double %f.add, ptr addrspace(1) %e seq_cst, align 8
394380

395-
; TODO: LLVM IR Verifier does not support atomics on vector types.
396-
397381
ret void
398382
}
399383

@@ -437,8 +421,6 @@ define void @shared_acq_rel(ptr addrspace(3) %a, ptr addrspace(3) %b, ptr addrsp
437421
; CHECK: st.release.sys.shared.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
438422
store atomic double %f.add, ptr addrspace(3) %e release, align 8
439423

440-
; TODO: LLVM IR Verifier does not support atomics on vector types.
441-
442424
ret void
443425
}
444426

@@ -480,8 +462,6 @@ define void @shared_acq_rel_volatile(ptr addrspace(3) %a, ptr addrspace(3) %b, p
480462
; CHECK: st.release.sys.shared.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
481463
store atomic volatile double %f.add, ptr addrspace(3) %e release, align 8
482464

483-
; TODO: LLVM IR Verifier does not support atomics on vector types.
484-
485465
ret void
486466
}
487467

@@ -535,8 +515,6 @@ define void @shared_seq_cst(ptr addrspace(3) %a, ptr addrspace(3) %b, ptr addrsp
535515
; CHECK: st.release.sys.shared.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
536516
store atomic double %f.add, ptr addrspace(3) %e seq_cst, align 8
537517

538-
; TODO: LLVM IR Verifier does not support atomics on vector types.
539-
540518
ret void
541519
}
542520

@@ -590,16 +568,15 @@ define void @shared_seq_cst_volatile(ptr addrspace(3) %a, ptr addrspace(3) %b, p
590568
; CHECK: st.release.sys.shared.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
591569
store atomic volatile double %f.add, ptr addrspace(3) %e seq_cst, align 8
592570

593-
; TODO: LLVM IR Verifier does not support atomics on vector types.
594-
595571
ret void
596572
}
597573

598574
;; local statespace
599575

600576
; CHECK-LABEL: local_acq_rel
601577
define void @local_acq_rel(ptr addrspace(5) %a, ptr addrspace(5) %b, ptr addrspace(5) %c, ptr addrspace(5) %d, ptr addrspace(5) %e) local_unnamed_addr {
602-
; TODO: this codegen looses Concurrent Forward Progress
578+
; TODO: generate PTX that preserves Concurrent Forward Progress
579+
; by using PTX atomic operations.
603580

604581
; CHECK: ld.local.u8 %rs{{[0-9]+}}, [%rd{{[0-9]+}}]
605582
%a.load = load atomic i8, ptr addrspace(5) %a acquire, align 1
@@ -637,14 +614,13 @@ define void @local_acq_rel(ptr addrspace(5) %a, ptr addrspace(5) %b, ptr addrspa
637614
; CHECK: st.local.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
638615
store atomic double %f.add, ptr addrspace(5) %e release, align 8
639616

640-
; TODO: LLVM IR Verifier does not support atomics on vector types.
641-
642617
ret void
643618
}
644619

645620
; CHECK-LABEL: local_acq_rel_volatile
646621
define void @local_acq_rel_volatile(ptr addrspace(5) %a, ptr addrspace(5) %b, ptr addrspace(5) %c, ptr addrspace(5) %d, ptr addrspace(5) %e) local_unnamed_addr {
647-
; TODO: this codegen looses Concurrent Forward Progress
622+
; TODO: generate PTX that preserves Concurrent Forward Progress
623+
; by using PTX atomic operations.
648624

649625
; CHECK: ld.local.u8 %rs{{[0-9]+}}, [%rd{{[0-9]+}}]
650626
%a.load = load atomic volatile i8, ptr addrspace(5) %a acquire, align 1
@@ -682,14 +658,13 @@ define void @local_acq_rel_volatile(ptr addrspace(5) %a, ptr addrspace(5) %b, pt
682658
; CHECK: st.local.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
683659
store atomic volatile double %f.add, ptr addrspace(5) %e release, align 8
684660

685-
; TODO: LLVM IR Verifier does not support atomics on vector types.
686-
687661
ret void
688662
}
689663

690664
; CHECK-LABEL: local_seq_cst
691665
define void @local_seq_cst(ptr addrspace(5) %a, ptr addrspace(5) %b, ptr addrspace(5) %c, ptr addrspace(5) %d, ptr addrspace(5) %e) local_unnamed_addr {
692-
; TODO: this codegen looses Concurrent Forward Progress
666+
; TODO: generate PTX that preserves Concurrent Forward Progress
667+
; by using PTX atomic operations.
693668

694669
; CHECK: ld.local.u8 %rs{{[0-9]+}}, [%rd{{[0-9]+}}]
695670
%a.load = load atomic i8, ptr addrspace(5) %a seq_cst, align 1
@@ -727,14 +702,13 @@ define void @local_seq_cst(ptr addrspace(5) %a, ptr addrspace(5) %b, ptr addrspa
727702
; CHECK: st.local.f64 [%rd{{[0-9]+}}], %fd{{[0-9]+}}
728703
store atomic double %f.add, ptr addrspace(5) %e seq_cst, align 8
729704

730-
; TODO: LLVM IR Verifier does not support atomics on vector types.
731-
732705
ret void
733706
}
734707

735708
; CHECK-LABEL: local_seq_cst_volatile
736709
define void @local_seq_cst_volatile(ptr addrspace(5) %a, ptr addrspace(5) %b, ptr addrspace(5) %c, ptr addrspace(5) %d, ptr addrspace(5) %e) local_unnamed_addr {
737-
; TODO: this codegen looses Concurrent Forward Progress
710+
; TODO: generate PTX that preserves Concurrent Forward Progress
711+
; by using PTX atomic operations.
738712

739713
; CHECK: ld.local.u8 %rs{{[0-9]+}}, [%rd{{[0-9]+}}]
740714
%a.load = load atomic volatile i8, ptr addrspace(5) %a seq_cst, align 1
@@ -777,5 +751,5 @@ define void @local_seq_cst_volatile(ptr addrspace(5) %a, ptr addrspace(5) %b, pt
777751
ret void
778752
}
779753

780-
; TODO: missing .const statespace tests
781-
; TODO: missing .param statespace tests
754+
; TODO: add plain,atomic,volatile,atomic volatile tests
755+
; for .const and .param statespaces

0 commit comments

Comments
 (0)