Skip to content

Commit c4e01f6

Browse files
Fix review comments
1 parent 4739878 commit c4e01f6

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

flang/include/flang/Semantics/semantics.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ class SemanticsContext {
348348
UnorderedSymbolSet isDefined_;
349349
std::list<ProgramTree> programTrees_;
350350

351-
// storage for mangled names used in OMP DECLARE REDUCTION.
351+
// Storage for mangled names used in OMP DECLARE REDUCTION.
352352
// use std::list to avoid re-allocating the string when adding
353353
// more content to the container.
354354
std::list<std::string> userReductionNames_;

flang/lib/Semantics/check-omp-structure.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3498,7 +3498,7 @@ void OmpStructureChecker::CheckReductionObjects(
34983498

34993499
static bool CheckSymbolSupportsType(const Scope &scope,
35003500
const parser::CharBlock &name, const DeclTypeSpec &type) {
3501-
if (const auto &symbol{scope.FindSymbol(name)}) {
3501+
if (const auto *symbol{scope.FindSymbol(name)}) {
35023502
if (const auto *reductionDetails{
35033503
symbol->detailsIf<UserReductionDetails>()}) {
35043504
return reductionDetails->SupportsType(type);

flang/lib/Semantics/mod-file.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
#include "mod-file.h"
1010
#include "resolve-names.h"
11-
#include "flang/Common/indirection.h"
1211
#include "flang/Common/restorer.h"
1312
#include "flang/Evaluate/tools.h"
1413
#include "flang/Parser/message.h"

flang/lib/Semantics/resolve-names.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1842,7 +1842,7 @@ void OmpVisitor::ProcessReductionSpecifier(
18421842
reductionDetails = symbol->detailsIf<UserReductionDetails>();
18431843

18441844
if (!reductionDetails) {
1845-
context().Say(name->source,
1845+
context().Say(
18461846
"Duplicate definition of '%s' in DECLARE REDUCTION"_err_en_US,
18471847
name->source);
18481848
return;

0 commit comments

Comments
 (0)