Skip to content

Commit c36dd88

Browse files
Jlalondsvkeerthy
authored andcommitted
[LLDB][Minidump] Fix bug in generating 64b memory minidumps (#141995)
In #129307, we introduced read write in chunks, and during the final revision of the PR I changed the behavior for 64b memory regions and did not test an actual 64b memory range. This caused LLDB to crash whenever we generated a 64b memory region. 64b regions has been a problem in testing for some time as it's a waste of test resources to generation a 5gb+ Minidump. I will work with @clayborg and @labath to come up with a way to specify creating a 64b list instead of a 32b list (likely via the yamilizer).
1 parent 98be759 commit c36dd88

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1170,7 +1170,6 @@ MinidumpFileBuilder::AddMemoryList_64(std::vector<CoreFileMemoryRange> &ranges,
11701170
"(%" PRIx64 "bytes) "
11711171
"[%" PRIx64 ", %" PRIx64 ")",
11721172
region_index, ranges.size(), size, addr, addr + size);
1173-
++region_index;
11741173

11751174
progress.Increment(1, "Adding Memory Range " + core_range.Dump());
11761175
uint64_t bytes_read = 0;
@@ -1186,6 +1185,8 @@ MinidumpFileBuilder::AddMemoryList_64(std::vector<CoreFileMemoryRange> &ranges,
11861185
cleanup_required = true;
11871186
descriptors[region_index].DataSize = bytes_read;
11881187
}
1188+
1189+
++region_index;
11891190
}
11901191

11911192
// Early return if there is no cleanup needed.

0 commit comments

Comments
 (0)