Skip to content

Commit b82fd71

Browse files
authored
[lldb] Adjust skips on reverse continue tests (#133240)
The x86-specific issue has been fixed with #132122. Watchpoint tests fail on aarch64 with macos<15.0 due to a kernel bug.
1 parent c13c04f commit b82fd71

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,10 @@
1010

1111
class TestReverseContinueBreakpoints(ReverseTestBase):
1212
@skipIfRemote
13-
@skipIf(macos_version=["<", "15.0"])
1413
def test_reverse_continue(self):
1514
self.reverse_continue_internal(async_mode=False)
1615

1716
@skipIfRemote
18-
@skipIf(macos_version=["<", "15.0"])
1917
def test_reverse_continue_async(self):
2018
self.reverse_continue_internal(async_mode=True)
2119

@@ -44,12 +42,10 @@ def reverse_continue_internal(self, async_mode):
4442
self.assertEqual(process.GetExitStatus(), 0)
4543

4644
@skipIfRemote
47-
@skipIf(macos_version=["<", "15.0"])
4845
def test_reverse_continue_breakpoint(self):
4946
self.reverse_continue_breakpoint_internal(async_mode=False)
5047

5148
@skipIfRemote
52-
@skipIf(macos_version=["<", "15.0"])
5349
def test_reverse_continue_breakpoint_async(self):
5450
self.reverse_continue_breakpoint_internal(async_mode=True)
5551

@@ -67,12 +63,10 @@ def reverse_continue_breakpoint_internal(self, async_mode):
6763
self.assertEqual(threads_now, initial_threads)
6864

6965
@skipIfRemote
70-
@skipIf(macos_version=["<", "15.0"])
7166
def test_reverse_continue_skip_breakpoint(self):
7267
self.reverse_continue_skip_breakpoint_internal(async_mode=False)
7368

7469
@skipIfRemote
75-
@skipIf(macos_version=["<", "15.0"])
7670
def test_reverse_continue_skip_breakpoint_async(self):
7771
self.reverse_continue_skip_breakpoint_internal(async_mode=True)
7872

@@ -97,12 +91,10 @@ def reverse_continue_skip_breakpoint_internal(self, async_mode):
9791
)
9892

9993
@skipIfRemote
100-
@skipIf(macos_version=["<", "15.0"])
10194
def test_continue_preserves_direction(self):
10295
self.continue_preserves_direction_internal(async_mode=False)
10396

10497
@skipIfRemote
105-
@skipIf(macos_version=["<", "15.0"])
10698
def test_continue_preserves_direction_asyhc(self):
10799
self.continue_preserves_direction_internal(async_mode=True)
108100

lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,14 @@
1010

1111
class TestReverseContinueWatchpoints(ReverseTestBase):
1212
@skipIfRemote
13-
@skipIf(macos_version=["<", "15.0"])
13+
# Watchpoints don't work in single-step mode
14+
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
1415
def test_reverse_continue_watchpoint(self):
1516
self.reverse_continue_watchpoint_internal(async_mode=False)
1617

1718
@skipIfRemote
18-
@skipIf(macos_version=["<", "15.0"])
19+
# Watchpoints don't work in single-step mode
20+
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
1921
def test_reverse_continue_watchpoint_async(self):
2022
self.reverse_continue_watchpoint_internal(async_mode=True)
2123

@@ -60,12 +62,14 @@ def reverse_continue_watchpoint_internal(self, async_mode):
6062
)
6163

6264
@skipIfRemote
63-
@skipIf(macos_version=["<", "15.0"])
65+
# Watchpoints don't work in single-step mode
66+
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
6467
def test_reverse_continue_skip_watchpoint(self):
6568
self.reverse_continue_skip_watchpoint_internal(async_mode=False)
6669

6770
@skipIfRemote
68-
@skipIf(macos_version=["<", "15.0"])
71+
# Watchpoints don't work in single-step mode
72+
@skipIf(macos_version=["<", "15.0"], archs=["arm64"])
6973
def test_reverse_continue_skip_watchpoint_async(self):
7074
self.reverse_continue_skip_watchpoint_internal(async_mode=True)
7175

0 commit comments

Comments
 (0)