Skip to content

Commit b4e5c7c

Browse files
committed
Address more comments
1 parent 0c121bb commit b4e5c7c

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2999,15 +2999,14 @@ WinogradInputTransformOp::getTiledImplementation(OpBuilder &builder,
29992999
tiledOperands.emplace_back(builder.create<tensor::ExtractSliceOp>(
30003000
loc, getInput(), sliceOffsets, sliceSizes, inputStrides));
30013001

3002-
sliceOffsets.clear();
3003-
sliceSizes.clear();
3004-
if (failed(getResultTilePosition(builder, 1, offsets, sizes, sliceOffsets,
3005-
sliceSizes)))
3002+
SmallVector<OpFoldResult> resultOffsets, resultSizes;
3003+
if (failed(getResultTilePosition(builder, 1, offsets, sizes, resultOffsets,
3004+
resultSizes)))
30063005
return failure();
30073006

30083007
SmallVector<OpFoldResult> outputStrides(6, oneAttr);
30093008
tiledOperands.emplace_back(builder.create<tensor::ExtractSliceOp>(
3010-
loc, getOutput(), sliceOffsets, sliceSizes, outputStrides));
3009+
loc, getOutput(), resultOffsets, resultSizes, outputStrides));
30113010

30123011
SmallVector<Type> resultTypes;
30133012
resultTypes.push_back(tiledOperands[1].getType());
@@ -3128,15 +3127,14 @@ FailureOr<TilingResult> WinogradOutputTransformOp::getTiledImplementation(
31283127
tiledOperands.emplace_back(builder.create<tensor::ExtractSliceOp>(
31293128
loc, getValue(), sliceOffsets, sliceSizes, sliceStrides));
31303129

3131-
sliceOffsets.clear();
3132-
sliceSizes.clear();
3133-
if (failed(getResultTilePosition(builder, 1, offsets, sizes, sliceOffsets,
3134-
sliceSizes)))
3130+
SmallVector<OpFoldResult> resultOffsets, resultSizes;
3131+
if (failed(getResultTilePosition(builder, 1, offsets, sizes, resultOffsets,
3132+
resultSizes)))
31353133
return failure();
31363134

31373135
SmallVector<OpFoldResult> strides(4, oneAttr);
31383136
tiledOperands.emplace_back(builder.create<tensor::ExtractSliceOp>(
3139-
loc, getOutput(), sliceOffsets, sliceSizes, strides));
3137+
loc, getOutput(), resultOffsets, resultSizes, strides));
31403138

31413139
SmallVector<Type> resultTypes;
31423140
resultTypes.push_back(tiledOperands[1].getType());

0 commit comments

Comments
 (0)