Skip to content

Commit ae1de3e

Browse files
committed
[Flang] Remove tests checking now removed 'libc-gpu.a`
Summary: These tests were removed in a previous patch. The linker wrapper now just extracts the device inputs and forwards them directly to the device's link job. This is the job that occurs when you do `clang --target=amdgcn-amd-amdhsa foo.o` or similar. Because this can handle LTO we no longer do LTO in the linker wrapper. This has some fallout, because we now require `ld.lld` to be built with a compatible version, but I think we always expected that. I made the decision to remove this `libc-gpu.a` library because it was unnecessary and complicated things. Now I simply have the link job implicitly link `-lc` if it exists. Users can also now pass `-Xoffload-linker=amdgcn-amd-amdhsa -lc` or similar to pass it. Because of this, these tests need to be removed. I forgot that Fortran also had these.
1 parent ea4a348 commit ae1de3e

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

flang/test/Driver/omp-driver-offload.f90

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -175,33 +175,6 @@
175175
! RUN: | FileCheck %s --check-prefix=HOST-IR-MISSING
176176
! HOST-IR-MISSING: error: provided host compiler IR file 'non-existant-file.bc' is required to generate code for OpenMP target regions but cannot be found
177177

178-
! Check that `-gpulibc` includes the LLVM C libraries for the GPU.
179-
! RUN: %flang -### --target=x86_64-unknown-linux-gnu -fopenmp \
180-
! RUN: --offload-arch=sm_52 \
181-
! RUN: -gpulibc %s 2>&1 \
182-
! RUN: | FileCheck --check-prefix=LIBC-GPU-NVPTX %s
183-
! LIBC-GPU-NVPTX-DAG: "-lcgpu-nvptx"
184-
! LIBC-GPU-NVPTX-DAG: "-lmgpu-nvptx"
185-
186-
! RUN: %flang -### --target=x86_64-unknown-linux-gnu -fopenmp \
187-
! RUN: --offload-arch=sm_52 \
188-
! RUN: -nogpulibc %s 2>&1 \
189-
! RUN: | FileCheck --check-prefix=NO-LIBC-GPU-NVPTX %s
190-
! NO-LIBC-GPU-NVPTX-NOT: "-lcgpu-nvptx"
191-
192-
! RUN: %flang -### --target=x86_64-unknown-linux-gnu -fopenmp \
193-
! RUN: --offload-arch=gfx90a \
194-
! RUN: -gpulibc %s 2>&1 \
195-
! RUN: | FileCheck --check-prefix=LIBC-GPU-AMDGPU %s
196-
! LIBC-GPU-AMDGPU-DAG: "-lcgpu-amdgpu"
197-
! LIBC-GPU-AMDGPU-DAG: "-lmgpu-amdgpu"
198-
199-
! RUN: %flang -### --target=x86_64-unknown-linux-gnu -fopenmp \
200-
! RUN: --offload-arch=gfx90a \
201-
! RUN: -nogpulibc %s 2>&1 \
202-
! RUN: | FileCheck --check-prefix=NO-LIBC-GPU-AMDGPU %s
203-
! NO-LIBC-GPU-AMDGPU-NOT: "-lcgpu-amdgpu"
204-
205178
! RUN: %flang -### -v --target=x86_64-unknown-linux-gnu -fopenmp \
206179
! RUN: --offload-arch=gfx900 \
207180
! RUN: --rocm-path=%S/Inputs/rocm %s 2>&1 \

0 commit comments

Comments
 (0)