[InstCombine] Use getAllOnesValue()

nikic · nikic · commit adb4cfe0b618 · 2024-08-13T15:04:23.000+02:00
Split off from #80309.
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
@@ -312,7 +312,7 @@ Instruction *InstCombinerImpl::foldCmpLoadFromIndexedGlobal(
       DL.getTypeAllocSize(Init->getType()->getArrayElementType());
   auto MaskIdx = [&](Value *Idx) {
     if (!GEP->isInBounds() && llvm::countr_zero(ElementSize) != 0) {
-      Value *Mask = ConstantInt::get(Idx->getType(), -1);
+      Value *Mask = Constant::getAllOnesValue(Idx->getType());
       Mask = Builder.CreateLShr(Mask, llvm::countr_zero(ElementSize));
       Idx = Builder.CreateAnd(Idx, Mask);
     }

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ Instruction *InstCombinerImpl::foldCmpLoadFromIndexedGlobal(`
`312`	`312`	`DL.getTypeAllocSize(Init->getType()->getArrayElementType());`
`313`	`313`	`auto MaskIdx = [&](Value *Idx) {`
`314`	`314`	`if (!GEP->isInBounds() && llvm::countr_zero(ElementSize) != 0) {`
`315`		`- Value *Mask = ConstantInt::get(Idx->getType(), -1);`
	`315`	`+ Value *Mask = Constant::getAllOnesValue(Idx->getType());`
`316`	`316`	`Mask = Builder.CreateLShr(Mask, llvm::countr_zero(ElementSize));`
`317`	`317`	`Idx = Builder.CreateAnd(Idx, Mask);`
`318`	`318`	`}`