Skip to content

Commit a60a522

Browse files
committed
add document in test
1 parent 0b280fe commit a60a522

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

bolt/lib/Core/BinaryFunction.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1706,12 +1706,11 @@ bool BinaryFunction::scanExternalRefs() {
17061706
: TargetFunction->getSymbol();
17071707
} else {
17081708
TargetFunction->setIgnored();
1709-
Success = false;
17101709
BC.outs() << "BOLT-WARNING: Ignoring entry point at address 0x"
17111710
<< Twine::utohexstr(Address)
17121711
<< " in constant island of function " << *TargetFunction
17131712
<< '\n';
1714-
break;
1713+
continue;
17151714
}
17161715
}
17171716

bolt/test/AArch64/constant-island-entry.s

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1-
// This test checks that we ignore functions which add an entry point that
2-
// is in a constant island.
1+
## This test checks that we ignore functions which add an entry point that
2+
## is in a constant island.
33

44
# RUN: llvm-mc -filetype=obj -triple aarch64-unknown-unknown %s -o %t.o
55
# RUN: %clang %cflags %t.o -pie -Wl,-q -o %t.exe
6+
7+
## Check when the caller is successfully disassembled.
68
# RUN: llvm-bolt %t.exe -o %t.bolt 2>&1 | FileCheck %s
9+
10+
## Skip caller to check the identical warning is triggered from ScanExternalRefs().
711
# RUN: llvm-bolt %t.exe -o %t.bolt -skip-funcs=caller 2>&1 | FileCheck %s
812

913
# CHECK: BOLT-WARNING: Ignoring entry point at address 0x{{[0-9a-f]+}} in constant island of function func

0 commit comments

Comments
 (0)