Skip to content

Commit 93b91dd

Browse files
authored
[lldb] Tighten ABI assert in StopInfoMachException::DeterminePtrauthFailure (NFC) (#95015)
This patch tightens the assert check for the ABISP object in `StopInfoMachException::DeterminePtrauthFailure`. This causes some failure when debugging on a system that doesn't have pointer authentification support, like on Intel for instance. rdar://129401926 Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
1 parent 61df854 commit 93b91dd

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,7 @@ bool StopInfoMachException::DeterminePtrauthFailure(ExecutionContext &exe_ctx) {
9292

9393
Target &target = *exe_ctx.GetTargetPtr();
9494
Process &process = *exe_ctx.GetProcessPtr();
95-
ABISP abi_sp = process.GetABI();
9695
const ArchSpec &arch = target.GetArchitecture();
97-
assert(abi_sp && "Missing ABI info");
9896

9997
// Check for a ptrauth-enabled target.
10098
const bool ptrauth_enabled_target =
@@ -110,6 +108,9 @@ bool StopInfoMachException::DeterminePtrauthFailure(ExecutionContext &exe_ctx) {
110108
strm.Printf("Note: Possible pointer authentication failure detected.\n");
111109
};
112110

111+
ABISP abi_sp = process.GetABI();
112+
assert(abi_sp && "Missing ABI info");
113+
113114
// Check if we have a "brk 0xc47x" trap, where the value that failed to
114115
// authenticate is in x16.
115116
Address current_address = current_frame->GetFrameCodeAddress();

0 commit comments

Comments
 (0)