use signed for arithemtic & avoid copy

Author: chios202

mlir/include/mlir/Query/Matcher/Marshallers.h

@@ -177,7 +177,7 @@ class VariadicOperatorMatcherDescriptor : public MatcherDescriptor {
     }
 
     std::vector<VariantMatcher> innerArgs;
-    for (size_t i = 0, e = args.size(); i != e; ++i) {
+    for (int64_t i = 0, e = args.size(); i != e; ++i) {
       const ParserValue &arg = args[i];
       const VariantValue &value = arg.value;
       if (!value.isMatcher()) {

mlir/include/mlir/Query/Matcher/MatchersInternal.h

@@ -102,7 +102,8 @@ using VariadicOperatorFunction = bool (*)(Operation *op,
 template <VariadicOperatorFunction Func>
 class VariadicMatcher : public MatcherInterface {
 public:
-  VariadicMatcher(std::vector<DynMatcher> matchers) : matchers(matchers) {}
+  VariadicMatcher(std::vector<DynMatcher> matchers)
+      : matchers(std::move(matchers)) {}
 
   bool match(Operation *op) override { return Func(op, nullptr, matchers); }
   bool match(Operation *op, SetVector<Operation *> &matchedOps) override {

mlir/test/mlir-query/logical-operator-test.mlir

@@ -1,4 +1,3 @@
-
 // RUN: mlir-query %s -c "m allOf(hasOpName(\"memref.alloca\"), hasOpAttrName(\"alignment\"))" | FileCheck %s
 
 func.func @dynamic_alloca(%arg0: index, %arg1: index) -> memref<?x?xf32> {
@@ -8,5 +7,5 @@ func.func @dynamic_alloca(%arg0: index, %arg1: index) -> memref<?x?xf32> {
 }
 
 // CHECK: Match #1:
-// CHECK: {{.*}}.mlir:6:3: note: "root" binds here
+// CHECK: {{.*}}.mlir:5:3: note: "root" binds here
 // CHECK: memref.alloca(%arg0, %arg1) {alignment = 32} : memref<?x?xf32>