Skip to content

Commit 80a5332

Browse files
[mlir] Remove redundant declarations (NFC) (#166896)
In C++17, static constexpr members are implicitly inline, so they no longer require an out-of-line definition. The comments for these variables are also present in: mlir/include/mlir/Dialect/Bufferization/IR/BufferizationBase.td Identified with readability-redundant-declaration.
1 parent de4d953 commit 80a5332

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

mlir/lib/Dialect/Bufferization/IR/BufferizationDialect.cpp

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -21,25 +21,6 @@ using namespace mlir::bufferization;
2121

2222
#include "mlir/Dialect/Bufferization/IR/BufferizationOpsDialect.cpp.inc"
2323

24-
/// Attribute name used to mark function arguments who's buffers can be written
25-
/// to during One-Shot Module Bufferize.
26-
constexpr const ::llvm::StringLiteral BufferizationDialect::kWritableAttrName;
27-
28-
/// Attribute name used to mark the bufferization layout for region arguments
29-
/// during One-Shot Module Bufferize.
30-
constexpr const ::llvm::StringLiteral
31-
BufferizationDialect::kBufferLayoutAttrName;
32-
33-
/// An attribute that can be attached to ops with an allocation and/or
34-
/// deallocation side effect. It indicates that the op is under a "manual
35-
/// deallocation" scheme. In the case of an allocation op, the returned
36-
/// value is *not* an automatically managed allocation and assigned an
37-
/// ownership of "false". Furthermore, only deallocation ops that are
38-
/// guaranteed to deallocate a buffer under "manual deallocation" are
39-
/// allowed to have this attribute. (Deallocation ops without this
40-
/// attribute are rejected by the ownership-based buffer deallocation pass.)
41-
constexpr const ::llvm::StringLiteral BufferizationDialect::kManualDeallocation;
42-
4324
//===----------------------------------------------------------------------===//
4425
// Bufferization Dialect Interfaces
4526
//===----------------------------------------------------------------------===//

0 commit comments

Comments
 (0)