Skip to content

Commit 73bbca1

Browse files
committed
Address more comments
1 parent 936356f commit 73bbca1

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2890,15 +2890,14 @@ WinogradInputTransformOp::getTiledImplementation(OpBuilder &builder,
28902890
tiledOperands.emplace_back(builder.create<tensor::ExtractSliceOp>(
28912891
loc, getInput(), sliceOffsets, sliceSizes, inputStrides));
28922892

2893-
sliceOffsets.clear();
2894-
sliceSizes.clear();
2895-
if (failed(getResultTilePosition(builder, 1, offsets, sizes, sliceOffsets,
2896-
sliceSizes)))
2893+
SmallVector<OpFoldResult> resultOffsets, resultSizes;
2894+
if (failed(getResultTilePosition(builder, 1, offsets, sizes, resultOffsets,
2895+
resultSizes)))
28972896
return failure();
28982897

28992898
SmallVector<OpFoldResult> outputStrides(6, oneAttr);
29002899
tiledOperands.emplace_back(builder.create<tensor::ExtractSliceOp>(
2901-
loc, getOutput(), sliceOffsets, sliceSizes, outputStrides));
2900+
loc, getOutput(), resultOffsets, resultSizes, outputStrides));
29022901

29032902
SmallVector<Type> resultTypes;
29042903
resultTypes.push_back(tiledOperands[1].getType());
@@ -3019,15 +3018,14 @@ FailureOr<TilingResult> WinogradOutputTransformOp::getTiledImplementation(
30193018
tiledOperands.emplace_back(builder.create<tensor::ExtractSliceOp>(
30203019
loc, getValue(), sliceOffsets, sliceSizes, sliceStrides));
30213020

3022-
sliceOffsets.clear();
3023-
sliceSizes.clear();
3024-
if (failed(getResultTilePosition(builder, 1, offsets, sizes, sliceOffsets,
3025-
sliceSizes)))
3021+
SmallVector<OpFoldResult> resultOffsets, resultSizes;
3022+
if (failed(getResultTilePosition(builder, 1, offsets, sizes, resultOffsets,
3023+
resultSizes)))
30263024
return failure();
30273025

30283026
SmallVector<OpFoldResult> strides(4, oneAttr);
30293027
tiledOperands.emplace_back(builder.create<tensor::ExtractSliceOp>(
3030-
loc, getOutput(), sliceOffsets, sliceSizes, strides));
3028+
loc, getOutput(), resultOffsets, resultSizes, strides));
30313029

30323030
SmallVector<Type> resultTypes;
30333031
resultTypes.push_back(tiledOperands[1].getType());

0 commit comments

Comments
 (0)