Skip to content

Commit 69f2ff3

Browse files
committed
[LV] Add test case showing unnecessary broadcast of invariant GEP idx.
1 parent 3f3b19d commit 69f2ff3

File tree

1 file changed

+64
-7
lines changed

1 file changed

+64
-7
lines changed

llvm/test/Transforms/LoopVectorize/widen-gep-all-indices-invariant.ll

Lines changed: 64 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@ define void @pr63340(ptr %A, ptr %B) {
77
; CHECK-NEXT: entry:
88
; CHECK-NEXT: br i1 false, label [[SCALAR_PH:%.*]], label [[VECTOR_PH:%.*]]
99
; CHECK: vector.ph:
10-
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr i8, ptr [[A]], i64 1
11-
; CHECK-NEXT: [[DOTSPLATINSERT:%.*]] = insertelement <4 x ptr> poison, ptr [[TMP1]], i64 0
10+
; CHECK-NEXT: [[TMP0:%.*]] = getelementptr i8, ptr [[A]], i64 1
11+
; CHECK-NEXT: [[DOTSPLATINSERT:%.*]] = insertelement <4 x ptr> poison, ptr [[TMP0]], i64 0
1212
; CHECK-NEXT: [[DOTSPLAT:%.*]] = shufflevector <4 x ptr> [[DOTSPLATINSERT]], <4 x ptr> poison, <4 x i32> zeroinitializer
1313
; CHECK-NEXT: br label [[VECTOR_BODY:%.*]]
1414
; CHECK: vector.body:
1515
; CHECK-NEXT: [[INDEX:%.*]] = phi i32 [ 0, [[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], [[VECTOR_BODY]] ]
1616
; CHECK-NEXT: [[OFFSET_IDX:%.*]] = trunc i32 [[INDEX]] to i8
17-
; CHECK-NEXT: [[TMP2:%.*]] = getelementptr inbounds ptr, ptr [[B]], i8 [[OFFSET_IDX]]
18-
; CHECK-NEXT: [[TMP3:%.*]] = getelementptr inbounds ptr, ptr [[TMP2]], i32 0
19-
; CHECK-NEXT: store <4 x ptr> [[DOTSPLAT]], ptr [[TMP3]], align 8
17+
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds ptr, ptr [[B]], i8 [[OFFSET_IDX]]
18+
; CHECK-NEXT: [[TMP2:%.*]] = getelementptr inbounds ptr, ptr [[TMP1]], i32 0
19+
; CHECK-NEXT: store <4 x ptr> [[DOTSPLAT]], ptr [[TMP2]], align 8
2020
; CHECK-NEXT: [[INDEX_NEXT]] = add nuw i32 [[INDEX]], 4
21-
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[INDEX_NEXT]], 128
22-
; CHECK-NEXT: br i1 [[TMP4]], label [[MIDDLE_BLOCK:%.*]], label [[VECTOR_BODY]], !llvm.loop [[LOOP0:![0-9]+]]
21+
; CHECK-NEXT: [[TMP3:%.*]] = icmp eq i32 [[INDEX_NEXT]], 128
22+
; CHECK-NEXT: br i1 [[TMP3]], label [[MIDDLE_BLOCK:%.*]], label [[VECTOR_BODY]], !llvm.loop [[LOOP0:![0-9]+]]
2323
; CHECK: middle.block:
2424
; CHECK-NEXT: br i1 true, label [[EXIT:%.*]], label [[SCALAR_PH]]
2525
; CHECK: scalar.ph:
@@ -58,3 +58,60 @@ loop.latch:
5858
exit:
5959
ret void
6060
}
61+
62+
; FIXME: Redundant broadcast in vector.ph only feeds an extract only.
63+
define void @wide_gep_index_invariant(ptr noalias %dst, ptr noalias %src, i64 %n) {
64+
; CHECK-LABEL: define void @wide_gep_index_invariant
65+
; CHECK-SAME: (ptr noalias [[DST:%.*]], ptr noalias [[SRC:%.*]], i64 [[N:%.*]]) {
66+
; CHECK-NEXT: entry:
67+
; CHECK-NEXT: br i1 false, label [[SCALAR_PH:%.*]], label [[VECTOR_PH:%.*]]
68+
; CHECK: vector.ph:
69+
; CHECK-NEXT: [[BROADCAST_SPLATINSERT:%.*]] = insertelement <4 x i64> poison, i64 [[N]], i64 0
70+
; CHECK-NEXT: [[BROADCAST_SPLAT:%.*]] = shufflevector <4 x i64> [[BROADCAST_SPLATINSERT]], <4 x i64> poison, <4 x i32> zeroinitializer
71+
; CHECK-NEXT: br label [[VECTOR_BODY:%.*]]
72+
; CHECK: vector.body:
73+
; CHECK-NEXT: [[INDEX:%.*]] = phi i64 [ 0, [[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], [[VECTOR_BODY]] ]
74+
; CHECK-NEXT: [[TMP0:%.*]] = load ptr, ptr [[SRC]], align 8
75+
; CHECK-NEXT: [[BROADCAST_SPLATINSERT1:%.*]] = insertelement <4 x ptr> poison, ptr [[TMP0]], i64 0
76+
; CHECK-NEXT: [[BROADCAST_SPLAT2:%.*]] = shufflevector <4 x ptr> [[BROADCAST_SPLATINSERT1]], <4 x ptr> poison, <4 x i32> zeroinitializer
77+
; CHECK-NEXT: [[TMP1:%.*]] = extractelement <4 x i64> [[BROADCAST_SPLAT]], i32 0
78+
; CHECK-NEXT: [[TMP2:%.*]] = getelementptr float, <4 x ptr> [[BROADCAST_SPLAT2]], i64 [[TMP1]]
79+
; CHECK-NEXT: [[TMP3:%.*]] = getelementptr ptr, ptr [[DST]], i64 [[INDEX]]
80+
; CHECK-NEXT: [[TMP4:%.*]] = getelementptr ptr, ptr [[TMP3]], i32 0
81+
; CHECK-NEXT: store <4 x ptr> [[TMP2]], ptr [[TMP4]], align 8
82+
; CHECK-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 4
83+
; CHECK-NEXT: [[TMP5:%.*]] = icmp eq i64 [[INDEX_NEXT]], 100
84+
; CHECK-NEXT: br i1 [[TMP5]], label [[MIDDLE_BLOCK:%.*]], label [[VECTOR_BODY]], !llvm.loop [[LOOP4:![0-9]+]]
85+
; CHECK: middle.block:
86+
; CHECK-NEXT: br i1 true, label [[EXIT:%.*]], label [[SCALAR_PH]]
87+
; CHECK: scalar.ph:
88+
; CHECK-NEXT: [[BC_RESUME_VAL:%.*]] = phi i64 [ 100, [[MIDDLE_BLOCK]] ], [ 0, [[ENTRY:%.*]] ]
89+
; CHECK-NEXT: br label [[LOOP:%.*]]
90+
; CHECK: loop:
91+
; CHECK-NEXT: [[IV:%.*]] = phi i64 [ [[BC_RESUME_VAL]], [[SCALAR_PH]] ], [ [[IV_NEXT:%.*]], [[LOOP]] ]
92+
; CHECK-NEXT: [[L:%.*]] = load ptr, ptr [[SRC]], align 8
93+
; CHECK-NEXT: [[GEP_L:%.*]] = getelementptr float, ptr [[L]], i64 [[N]]
94+
; CHECK-NEXT: [[GEP_DST:%.*]] = getelementptr ptr, ptr [[DST]], i64 [[IV]]
95+
; CHECK-NEXT: store ptr [[GEP_L]], ptr [[GEP_DST]], align 8
96+
; CHECK-NEXT: [[IV_NEXT]] = add nuw nsw i64 [[IV]], 1
97+
; CHECK-NEXT: [[EC:%.*]] = icmp eq i64 [[IV_NEXT]], 100
98+
; CHECK-NEXT: br i1 [[EC]], label [[EXIT]], label [[LOOP]], !llvm.loop [[LOOP5:![0-9]+]]
99+
; CHECK: exit:
100+
; CHECK-NEXT: ret void
101+
;
102+
entry:
103+
br label %loop
104+
105+
loop:
106+
%iv = phi i64 [ 0, %entry ], [ %iv.next, %loop ]
107+
%l = load ptr, ptr %src, align 8
108+
%gep.l = getelementptr float, ptr %l, i64 %n
109+
%gep.dst = getelementptr ptr, ptr %dst, i64 %iv
110+
store ptr %gep.l, ptr %gep.dst, align 8
111+
%iv.next = add nuw nsw i64 %iv, 1
112+
%ec = icmp eq i64 %iv.next, 100
113+
br i1 %ec, label %exit, label %loop
114+
115+
exit:
116+
ret void
117+
}

0 commit comments

Comments
 (0)