Skip to content

Commit 5d26a6d

Browse files
[mlir][Interfaces] ViewLikeOpInterface: Remove parser/printer overloads (#122436)
#115808 adds additional `custom<>` parser/printer variants. The overall list of overloads/variants is getting larger. This commit removes overloads that are not needed, to keep the parser/printer simple.
1 parent 547ba97 commit 5d26a6d

File tree

2 files changed

+2
-37
lines changed

2 files changed

+2
-37
lines changed

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,7 +1118,7 @@ def AffineDelinearizeIndexOp : Affine_Op<"delinearize_index", [Pure]> {
11181118

11191119
let assemblyFormat = [{
11201120
$linear_index `into`
1121-
custom<DynamicIndexList>($dynamic_basis, $static_basis, "::mlir::AsmParser::Delimiter::Paren")
1121+
custom<DynamicIndexList>($dynamic_basis, $static_basis, "{}", "::mlir::AsmParser::Delimiter::Paren")
11221122
attr-dict `:` type($multi_index)
11231123
}];
11241124

@@ -1219,7 +1219,7 @@ def AffineLinearizeIndexOp : Affine_Op<"linearize_index",
12191219
let assemblyFormat = [{
12201220
(`disjoint` $disjoint^)? ` `
12211221
`[` $multi_index `]` `by`
1222-
custom<DynamicIndexList>($dynamic_basis, $static_basis, "::mlir::AsmParser::Delimiter::Paren")
1222+
custom<DynamicIndexList>($dynamic_basis, $static_basis, "{}", "::mlir::AsmParser::Delimiter::Paren")
12231223
attr-dict `:` type($linear_index)
12241224
}];
12251225

mlir/include/mlir/Interfaces/ViewLikeInterface.h

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,6 @@ void printDynamicIndexList(
109109
ArrayRef<int64_t> integers, ArrayRef<bool> scalables,
110110
TypeRange valueTypes = TypeRange(),
111111
AsmParser::Delimiter delimiter = AsmParser::Delimiter::Square);
112-
inline void printDynamicIndexList(OpAsmPrinter &printer, Operation *op,
113-
OperandRange values,
114-
ArrayRef<int64_t> integers,
115-
AsmParser::Delimiter delimiter) {
116-
return printDynamicIndexList(printer, op, values, integers, {}, TypeRange(),
117-
delimiter);
118-
}
119112
inline void printDynamicIndexList(
120113
OpAsmPrinter &printer, Operation *op, OperandRange values,
121114
ArrayRef<int64_t> integers, TypeRange valueTypes = TypeRange(),
@@ -151,15 +144,6 @@ ParseResult parseDynamicIndexList(
151144
DenseI64ArrayAttr &integers, DenseBoolArrayAttr &scalableVals,
152145
SmallVectorImpl<Type> *valueTypes = nullptr,
153146
AsmParser::Delimiter delimiter = AsmParser::Delimiter::Square);
154-
inline ParseResult
155-
parseDynamicIndexList(OpAsmParser &parser,
156-
SmallVectorImpl<OpAsmParser::UnresolvedOperand> &values,
157-
DenseI64ArrayAttr &integers,
158-
AsmParser::Delimiter delimiter) {
159-
DenseBoolArrayAttr scalableVals = {};
160-
return parseDynamicIndexList(parser, values, integers, scalableVals, nullptr,
161-
delimiter);
162-
}
163147
inline ParseResult parseDynamicIndexList(
164148
OpAsmParser &parser,
165149
SmallVectorImpl<OpAsmParser::UnresolvedOperand> &values,
@@ -169,25 +153,6 @@ inline ParseResult parseDynamicIndexList(
169153
return parseDynamicIndexList(parser, values, integers, scalableVals,
170154
valueTypes, delimiter);
171155
}
172-
inline ParseResult parseDynamicIndexList(
173-
OpAsmParser &parser,
174-
SmallVectorImpl<OpAsmParser::UnresolvedOperand> &values,
175-
DenseI64ArrayAttr &integers, SmallVectorImpl<Type> &valueTypes,
176-
AsmParser::Delimiter delimiter = AsmParser::Delimiter::Square) {
177-
DenseBoolArrayAttr scalableVals = {};
178-
return parseDynamicIndexList(parser, values, integers, scalableVals,
179-
&valueTypes, delimiter);
180-
}
181-
inline ParseResult parseDynamicIndexList(
182-
OpAsmParser &parser,
183-
SmallVectorImpl<OpAsmParser::UnresolvedOperand> &values,
184-
DenseI64ArrayAttr &integers, SmallVectorImpl<Type> &valueTypes,
185-
DenseBoolArrayAttr &scalableVals,
186-
AsmParser::Delimiter delimiter = AsmParser::Delimiter::Square) {
187-
188-
return parseDynamicIndexList(parser, values, integers, scalableVals,
189-
&valueTypes, delimiter);
190-
}
191156

192157
/// Verify that a the `values` has as many elements as the number of entries in
193158
/// `attr` for which `isDynamic` evaluates to true.

0 commit comments

Comments
 (0)