Skip to content

Commit 5a5c53e

Browse files
improve padding check
Signed-off-by: Nirvedh Meshram <nirvedh@gmail.com>
1 parent d9f526e commit 5a5c53e

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5324,17 +5324,14 @@ bool PackOp::requirePaddingValueStrict(ArrayRef<int64_t> inputShape,
53245324
invertPermutationVector(outerDimsPerm));
53255325
}
53265326
for (auto [pos, tileSize] : llvm::zip_equal(innerDimsPos, innerTiles)) {
5327-
if (ShapedType::isDynamic(inputShape[pos]))
5327+
if (ShapedType::isDynamic(inputShape[pos]) ||
5328+
ShapedType::isDynamic(outputTileSizes[pos]))
53285329
return true;
53295330
std::optional<int64_t> constantTile = getConstantIntValue(tileSize);
5330-
5331-
if (!constantTile) {
5332-
if (ShapedType::isStatic(outputTileSizes[pos]) &&
5333-
(inputShape[pos] % outputTileSizes[pos] != 0))
5334-
return true;
5335-
} else if (inputShape[pos] % (*constantTile) != 0) {
5331+
if (!constantTile)
5332+
return true;
5333+
if (inputShape[pos] % (*constantTile) != 0)
53365334
return true;
5337-
}
53385335
}
53395336
return false;
53405337
}

0 commit comments

Comments
 (0)